Clean up volunteers system invites tests

In general, system tests are expensive to run.

After reviewing the test, it turns out that most
of the scenarios here are already being tested in
the volunteers and invite request specs, so
the system tests were redundant.

Extracting additional tests from the system tests
to the respective request spec keeps the coverage
while taking less resources to run.

To ensure the new/edit volunteer form fields are still being rendered, and that
the Resend invitation button is now displayed after the volunteer
has accepted an invitation, these scenarios have been extracted to view tests,
which are significantly cheaper to run.

The invite expiration is already covered in the volunteers
model test.

The password setting scenarios are covered in the requests/users/
invitations_spec request tests.

Lastly, to keep factories creation to a minimum, the requests/volunteers_spec
has been refactored to reuse the exising factories and build new ones
instead of creating as much as possible to have a minimum test setup.

Author: stefannibrasil

spec/requests/volunteers_spec.rb

@@ -72,11 +72,13 @@
       expect(response).to be_successful
     end
 
-    it "does not render for volunteers" do
+    it "redirects to root_url and displays an unauthorized message" do
       sign_in volunteer
 
       get new_volunteer_path
-      expect(response).not_to be_successful
+      expect(response).to redirect_to(root_url)
+      follow_redirect!
+      expect(flash[:notice]).to match(/Sorry, you are not authorized to perform this action./)
     end
   end
 
@@ -121,81 +123,108 @@
         }
       end
 
-      it "creates a new volunteer and sends account_setup email" do
-        organization = create(:casa_org)
-        admin = create(:casa_admin, casa_org: organization)
-
-        sign_in admin
-        expect {
+      context "when the user is an admin" do
+        it "creates a new volunteer and sends account_setup email" do
+          sign_in admin
+          post volunteers_url, params: params
+          
+          expect(response).to have_http_status(:redirect)
+
+          last_email = ActionMailer::Base.deliveries.last
+          expect(last_email.to).to eq ["volunteer1@example.com"]
+          expect(last_email.subject).to eq("CASA Console invitation instructions")
+          expect(last_email.html_part.body.encoded).to include("your new Volunteer account")
+
+          volunteer = Volunteer.last
+          expect(volunteer.email).to eq("volunteer1@example.com")
+          expect(volunteer.display_name).to eq("Example")
+          expect(volunteer.casa_org).to eq(admin.casa_org)
+          expect(volunteer.invitation_created_at).to be_present
+          expect(volunteer.invitation_accepted_at).to be_nil
+          expect(response).to redirect_to edit_volunteer_path(volunteer)
+        end
+
+        it "sends a SMS when phone number exists" do
+          organization = build(:casa_org, twilio_enabled: true)
+          admin = build(:casa_admin, casa_org: organization)
+          params[:volunteer][:phone_number] = "+12222222222"
+          twilio_activation_success_stub = WebMockHelper.twilio_activation_success_stub("volunteer")
+          short_io_stub = WebMockHelper.short_io_stub_sms
+
+          sign_in admin
           post volunteers_url, params: params
-        }.to change { ActionMailer::Base.deliveries.count }.by(1)
 
-        expect(response).to have_http_status(:redirect)
-        volunteer = Volunteer.last
-        expect(volunteer.email).to eq("volunteer1@example.com")
-        expect(volunteer.display_name).to eq("Example")
-        expect(volunteer.casa_org).to eq(admin.casa_org)
-        expect(response).to redirect_to edit_volunteer_path(volunteer)
-      end
+          expect(short_io_stub).to have_been_requested.times(2)
+          expect(twilio_activation_success_stub).to have_been_requested.times(1)
+          expect(response).to have_http_status(:redirect)
+          follow_redirect!
+          expect(flash[:notice]).to match(/New volunteer created successfully. SMS has been sent!/)
+        end
 
-      it "sends a SMS when phone number exists" do
-        organization = create(:casa_org, twilio_enabled: true)
-        admin = create(:casa_admin, casa_org: organization)
-        params[:volunteer][:phone_number] = "+12222222222"
-        twilio_activation_success_stub = WebMockHelper.twilio_activation_success_stub("volunteer")
-        short_io_stub = WebMockHelper.short_io_stub_sms
+        it "does not send a SMS when phone number is not provided" do
+          organization = build(:casa_org, twilio_enabled: true)
+          admin = build(:casa_admin, casa_org: organization)
+          sign_in admin
 
-        sign_in admin
-        post volunteers_url, params: params
+          post volunteers_url, params: params
 
-        expect(short_io_stub).to have_been_requested.times(2)
-        expect(twilio_activation_success_stub).to have_been_requested.times(1)
-        expect(response).to have_http_status(:redirect)
-        follow_redirect!
-        expect(flash[:notice]).to match(/New volunteer created successfully. SMS has been sent!/)
-      end
+          expect(response).to have_http_status(:redirect)
+          follow_redirect!
+          expect(flash[:notice]).to match(/New volunteer created successfully./)
+        end
 
-      it "does not send a SMS when phone number is not provided" do
-        organization = create(:casa_org, twilio_enabled: true)
-        admin = create(:casa_admin, casa_org: organization)
-        sign_in admin
-        post volunteers_url, params: params
+        it "does not send a SMS when Twilio API has an error" do
+          org = build(:casa_org, twilio_account_sid: "articuno31", twilio_enabled: true)
+          admin = build(:casa_admin, casa_org: org)
+          twilio_activation_error_stub = WebMockHelper.twilio_activation_error_stub("volunteer")
+          short_io_stub = WebMockHelper.short_io_stub_sms
+          params[:volunteer][:phone_number] = "+12222222222"
 
-        expect(response).to have_http_status(:redirect)
-        follow_redirect!
-        expect(flash[:notice]).to match(/New volunteer created successfully./)
-      end
+          sign_in admin
+          post volunteers_url, params: params
 
-      it "does not send a SMS when Twilio API has an error" do
-        org = create(:casa_org, twilio_account_sid: "articuno31", twilio_enabled: true)
-        admin = create(:casa_admin, casa_org: org)
-        twilio_activation_error_stub = WebMockHelper.twilio_activation_error_stub("volunteer")
-        short_io_stub = WebMockHelper.short_io_stub_sms
-        params[:volunteer][:phone_number] = "+12222222222"
+          expect(short_io_stub).to have_been_requested.times(2) # TODO: why is this called at all?
+          expect(twilio_activation_error_stub).to have_been_requested.times(1)
+          expect(response).to have_http_status(:redirect)
+          follow_redirect!
+          expect(flash[:notice]).to match(/New volunteer created successfully. SMS not sent. Error: ./)
+        end
 
-        sign_in admin
-        post volunteers_url, params: params
+        it "does not send a SMS if the casa_org does not have Twilio enabled" do
+          params[:volunteer][:phone_number] = "+12222222222"
+          short_io_stub = WebMockHelper.short_io_stub_sms
 
-        expect(short_io_stub).to have_been_requested.times(2) # TODO: why is this called at all?
-        expect(twilio_activation_error_stub).to have_been_requested.times(1)
-        expect(response).to have_http_status(:redirect)
-        follow_redirect!
-        expect(flash[:notice]).to match(/New volunteer created successfully. SMS not sent. Error: ./)
-      end
+          sign_in admin
+          post volunteers_url, params: params
 
-      it "does not send a SMS if the casa_org does not have Twilio enabled" do
-        org = create(:casa_org, twilio_enabled: false)
-        admin = build(:casa_admin, casa_org: org)
-        params[:volunteer][:phone_number] = "+12222222222"
-        short_io_stub = WebMockHelper.short_io_stub_sms
+          expect(short_io_stub).to have_been_requested.times(2) # TODO: why is this called at all?
+          expect(response).to have_http_status(:redirect)
+          follow_redirect!
+          expect(flash[:notice]).to match(/New volunteer created successfully./)
+        end
+      end
 
-        sign_in admin
-        post volunteers_url, params: params
+      context "when the user is a supervisor" do
+        it "creates a new volunteer and sends account_setup email" do
+          sign_in supervisor
 
-        expect(short_io_stub).to have_been_requested.times(2) # TODO: why is this called at all?
-        expect(response).to have_http_status(:redirect)
-        follow_redirect!
-        expect(flash[:notice]).to match(/New volunteer created successfully./)
+          post volunteers_url, params: params
+          
+          expect(response).to have_http_status(:redirect)
+
+          last_email = ActionMailer::Base.deliveries.last
+          expect(last_email.to).to eq ["volunteer1@example.com"]
+          expect(last_email.subject).to eq("CASA Console invitation instructions")
+          expect(last_email.html_part.body.encoded).to include("your new Volunteer account")
+
+          volunteer = Volunteer.last
+          expect(volunteer.email).to eq("volunteer1@example.com")
+          expect(volunteer.display_name).to eq("Example")
+          expect(volunteer.casa_org).to eq(admin.casa_org)
+          expect(volunteer.invitation_created_at).to be_present
+          expect(volunteer.invitation_accepted_at).to be_nil
+          expect(response).to redirect_to edit_volunteer_path(volunteer)
+        end
       end
     end
 
@@ -210,9 +239,6 @@
       end
 
       it "does not create a new volunteer" do
-        org = create(:casa_org, twilio_enabled: false)
-        admin = build(:casa_admin, casa_org: org)
-
         sign_in admin
 
         expect {
@@ -364,11 +390,14 @@
       expect(volunteer.invitation_created_at.present?).to eq(false)
 
       get resend_invitation_volunteer_path(volunteer)
+
+      expect(flash[:notice]).to match(/Invitation sent/)
       volunteer.reload
 
       expect(volunteer.invitation_created_at.present?).to eq(true)
       expect(Devise.mailer.deliveries.count).to eq(1)
-      expect(Devise.mailer.deliveries.first.subject).to eq(I18n.t("devise.mailer.invitation_instructions.subject"))
+      expect(Devise.mailer.deliveries.first.to).to eq([volunteer.email])
+      expect(Devise.mailer.deliveries.first.subject).to eq("CASA Console invitation instructions")
       expect(response).to redirect_to(edit_volunteer_path(volunteer))
     end
   end