Merge pull request #6398 from Gabe-Torres/6380-rubocop-config-tune

Rubocop config tune up

Author: compwron

.rubocop.yml

@@ -1,6 +1,8 @@
 require:
-  - rubocop-capybara
   - rubocop-factory_bot
+
+plugins:
+  - rubocop-capybara
   - rubocop-rspec
   - rubocop-rspec_rails
 

spec/system/static/index_spec.rb

@@ -4,7 +4,7 @@
   context "when visiting the CASA volunteer landing page", :js do
     describe "when all organizations have logos" do
       before do
-        3.times { create(:casa_org, :with_logo, display_name: "CASA of Awesome") }
+        create_list(:casa_org, 3, :with_logo, display_name: "CASA of Awesome")
         visit root_path
       end
 

spec/system/volunteers/index_spec.rb

@@ -175,13 +175,7 @@
     # These tests are very flaky do to the use of datatables on this page.
     # If the page is switched over to Hotwire, should try to re-instate these tests.
     describe "Manage Volunteers button" do
-      let!(:volunteers) {
-        [
-          create(:volunteer, casa_org: organization),
-          create(:volunteer, casa_org: organization),
-          create(:volunteer, casa_org: organization)
-        ]
-      }
+      let!(:volunteers) { create_list(:volunteer, 3, casa_org: organization) }
 
       before do
         sign_in admin
@@ -229,13 +223,7 @@
     end
 
     describe "Select All Checkbox" do
-      let!(:volunteers) {
-        [
-          create(:volunteer, casa_org: organization),
-          create(:volunteer, casa_org: organization),
-          create(:volunteer, casa_org: organization)
-        ]
-      }
+      let!(:volunteers) { create_list(:volunteer, 3, casa_org: organization) }
 
       before do
         sign_in admin

spec/views/all_casa_admins/patch_notes/index.html.erb_spec.rb

@@ -2,12 +2,7 @@
 
 RSpec.describe "patch_notes/index", type: :view do
   let(:all_casa_admin) { build(:all_casa_admin) }
-  let!(:patch_notes) {
-    [
-      create(:patch_note),
-      create(:patch_note)
-    ]
-  }
+  let!(:patch_notes) { create_list(:patch_note, 2) }
 
   before do
     assign(:patch_notes, patch_notes)