Cover mailer in unit tests

System tests are for asserting things that the user
sees when interacting with the app. These mailer
assertions are better tested somewhere else such
as the requests specs.

Author: stefannibrasil

spec/requests/volunteers_spec.rb

@@ -358,9 +358,23 @@
   end
 
   describe "PATCH /resend_invitation" do
-    before { sign_in admin }
+    it "resends an invitation email as an admin" do
+      sign_in admin
+
+      expect(volunteer.invitation_created_at.present?).to eq(false)
+
+      get resend_invitation_volunteer_path(volunteer)
+      volunteer.reload
+
+      expect(volunteer.invitation_created_at.present?).to eq(true)
+      expect(Devise.mailer.deliveries.count).to eq(1)
+      expect(Devise.mailer.deliveries.first.subject).to eq(I18n.t("devise.mailer.invitation_instructions.subject"))
+      expect(response).to redirect_to(edit_volunteer_path(volunteer))
+    end
+
+    it "resends an invitation email as a supervisor" do
+      sign_in supervisor
 
-    it "resends an invitation email" do
       expect(volunteer.invitation_created_at.present?).to eq(false)
 
       get resend_invitation_volunteer_path(volunteer)
@@ -373,6 +387,98 @@
     end
   end
 
+  describe "PATCH /reminder" do
+    describe "as admin" do
+      it "emails the volunteer" do
+        organization = create(:casa_org)
+        admin = create(:casa_admin, casa_org_id: organization.id)
+        supervisor = build(:supervisor, casa_org: organization)
+        volunteer = create(:volunteer, supervisor: supervisor, casa_org_id: organization.id)
+
+        sign_in admin
+
+        patch reminder_volunteer_path(volunteer)
+
+        email = ActionMailer::Base.deliveries.last
+        expect(email).not_to be_nil
+        expect(email.to).to eq [volunteer.email]
+        expect(email.subject).to eq("Reminder to input case contacts")
+      end
+
+      it "cc's their supervisor and admin when the 'with_cc` param is present" do
+        admin = create(:casa_admin, casa_org_id: organization.id)
+        supervisor = build(:supervisor, casa_org: organization)
+        volunteer = create(:volunteer, supervisor: supervisor, casa_org_id: organization.id)
+
+        sign_in admin
+
+        patch reminder_volunteer_path(volunteer), params: {
+          with_cc: true
+        }
+
+        email = ActionMailer::Base.deliveries.last
+        expect(email).not_to be_nil
+        expect(email.to).to eq [volunteer.email]
+        expect(email.subject).to eq("Reminder to input case contacts")
+        expect(email.cc).to include(volunteer.supervisor.email)
+        expect(email.cc).to include(admin.email)
+      end
+    end
+
+    describe "as supervisor" do
+      it "emails the volunteer" do
+        organization = create(:casa_org)
+        supervisor = build(:supervisor, casa_org: organization)
+        volunteer = create(:volunteer, supervisor: supervisor, casa_org_id: organization.id)
+
+        sign_in supervisor
+
+        patch reminder_volunteer_path(volunteer)
+
+        email = ActionMailer::Base.deliveries.last
+        expect(email).not_to be_nil
+        expect(email.to).to eq [volunteer.email]
+        expect(email.subject).to eq("Reminder to input case contacts")
+      end
+
+      it "cc's their supervisor when the 'with_cc` param is present" do
+        organization = create(:casa_org)
+        supervisor = build(:supervisor, casa_org: organization)
+        volunteer = create(:volunteer, supervisor: supervisor, casa_org_id: organization.id)
+
+        sign_in supervisor
+
+        patch reminder_volunteer_path(volunteer), params: {
+          with_cc: true
+        }
+
+        email = ActionMailer::Base.deliveries.last
+        expect(email).not_to be_nil
+        expect(email.to).to eq [volunteer.email]
+        expect(email.subject).to eq("Reminder to input case contacts")
+        expect(email.cc).to eq([supervisor.email])
+      end
+    end
+
+    it "emails the volunteer without a supervisor" do
+      organization = create(:casa_org)
+      volunteer_without_supervisor = create(:volunteer)
+      supervisor = build(:supervisor, casa_org: organization)
+
+      sign_in supervisor
+
+      patch reminder_volunteer_path(volunteer_without_supervisor), params: {
+        with_cc: true
+      }
+
+      email = ActionMailer::Base.deliveries.last
+      expect(email).not_to be_nil
+      expect(email.to).to eq [volunteer_without_supervisor.email]
+      expect(email.subject).to eq("Reminder to input case contacts")
+      expect(email.cc).to be_empty
+    end
+  end
+
   describe "POST /send_reactivation_alert" do
     before do
       sign_in admin

spec/system/volunteers/edit_spec.rb

@@ -115,7 +115,7 @@
 
   describe "updating a volunteer's email" do
     context "with a valid email" do
-      it "sends volunteer a confirmation email and does not change the displayed email" do
+      it "displays a success for sending an email confirmation and does not change the displayed email" do
         volunteer = create(:volunteer, supervisor: supervisor, casa_org: organization)
         old_email = volunteer.email
 
@@ -124,16 +124,10 @@
 
         fill_in "Email", with: "newemail@example.com"
         click_on "Submit"
-        volunteer.reload
-
-        expect(ActionMailer::Base.deliveries.count).to eq(1)
-        expect(ActionMailer::Base.deliveries.first).to be_a(Mail::Message)
-        expect(ActionMailer::Base.deliveries.first.body.encoded)
-          .to match("Click here to confirm your email")
 
         expect(page).to have_text "Volunteer was successfully updated. Confirmation Email Sent."
         expect(page).to have_field("Email", with: old_email)
-        expect(volunteer.unconfirmed_email).to eq("newemail@example.com")
+        expect(volunteer.reload.unconfirmed_email).to eq("newemail@example.com")
       end
 
       it "succesfully displays the new email once the user confirms" do
@@ -373,10 +367,6 @@
       click_on "Resend Invitation"
 
       expect(page).to have_content("Invitation sent")
-
-      deliveries = ActionMailer::Base.deliveries
-      expect(deliveries.count).to eq(1)
-      expect(deliveries.last.subject).to have_text "CASA Console invitation instructions"
     end
   end
 
@@ -389,10 +379,6 @@
     click_on "Resend Invitation"
 
     expect(page).to have_content("Invitation sent")
-
-    deliveries = ActionMailer::Base.deliveries
-    expect(deliveries.count).to eq(1)
-    expect(deliveries.last.subject).to have_text "CASA Console invitation instructions"
   end
 
   describe "Send Reactivation (SMS)" do
@@ -436,21 +422,7 @@
       uncheck "with_cc"
       click_on "Send Reminder"
 
-      expect(ActionMailer::Base.deliveries.count).to eq(1)
-      expect(ActionMailer::Base.deliveries.first.cc).to be_empty
-    end
-
-    it "emails volunteer and cc's the supervisor" do
-      volunteer = create(:volunteer, supervisor: supervisor, casa_org_id: organization.id)
-
-      sign_in supervisor
-      visit edit_volunteer_path(volunteer)
-
-      check "with_cc"
-      click_on "Send Reminder"
-
-      expect(ActionMailer::Base.deliveries.count).to eq(1)
-      expect(ActionMailer::Base.deliveries.first.cc).to include(volunteer.supervisor.email)
+      expect(page).to have_content("Reminder sent to volunteer")
     end
 
     it "emails the volunteer without a supervisor" do
@@ -464,8 +436,7 @@
       check "with_cc"
       click_on "Send Reminder"
 
-      expect(ActionMailer::Base.deliveries.count).to eq(1)
-      expect(ActionMailer::Base.deliveries.first.cc).to be_empty
+      expect(page).to have_content("Reminder sent to volunteer")
     end
   end
 
@@ -481,20 +452,7 @@
 
       click_on "Send Reminder"
 
-      expect(ActionMailer::Base.deliveries.count).to eq(1)
-    end
-
-    it "emails the volunteer and cc's their supervisor and admin" do
-      volunteer = create(:volunteer, supervisor: supervisor, casa_org_id: organization.id)
-
-      sign_in admin
-      visit edit_volunteer_path(volunteer)
-      check "with_cc"
-      click_on "Send Reminder"
-
-      expect(ActionMailer::Base.deliveries.count).to eq(1)
-      expect(ActionMailer::Base.deliveries.first.cc).to include(volunteer.supervisor.email)
-      expect(ActionMailer::Base.deliveries.first.cc).to include(admin.email)
+      expect(page).to have_content("Reminder sent to volunteer")
     end
   end