spec improvements

Author: compwron

spec/models/casa_case_spec.rb

@@ -38,7 +38,7 @@
       end
 
       it "is valid today" do
-        casa_case = CasaCase.new(date_in_care: Time.now)
+        casa_case = CasaCase.new(date_in_care: Time.current)
         casa_case.valid?
         expect(casa_case.errors[:date_in_care]).to eq([])
       end
@@ -66,7 +66,7 @@
       end
 
       it "is valid today" do
-        casa_case = CasaCase.new(birth_month_year_youth: Time.now)
+        casa_case = CasaCase.new(birth_month_year_youth: Time.current)
         casa_case.valid?
         expect(casa_case.errors[:birth_month_year_youth]).to eq([])
       end
@@ -195,18 +195,18 @@
 
   describe ".should_transition" do
     it "returns only youth who should have transitioned but have not" do
-      not_transitioned_13_yo = build(:casa_case,
+      not_transitioned_13_yo = create(:casa_case,
         birth_month_year_youth: Date.current - 13.years)
-      transitioned_14_yo = build(:casa_case,
-        birth_month_year_youth: Date.current - 14.years)
-      not_transitioned_14_yo = create(:casa_case,
+      already_transitioned_15_yo = create(:casa_case,
+        birth_month_year_youth: Date.current - 15.years)
+      should_transition_14_yo = create(:casa_case,
         birth_month_year_youth: Date.current - 14.years)
       cases = CasaCase.should_transition
       aggregate_failures do
-        expect(cases.length).to eq 1
-        expect(cases.include?(not_transitioned_14_yo)).to eq true
+        expect(cases.length).to eq 2
+        expect(cases.include?(should_transition_14_yo)).to eq true
+        expect(cases.include?(already_transitioned_15_yo)).to eq true
         expect(cases.include?(not_transitioned_13_yo)).to eq false
-        expect(cases.include?(transitioned_14_yo)).to eq false
       end
     end
   end
@@ -228,7 +228,7 @@
     let(:casa_case) { create(:casa_case) }
     let(:emancipation_category) { create(:emancipation_category) }
 
-    it "associates an emacipation category with the case when passed the id of the category" do
+    it "associates an emancipation category with the case when passed the id of the category" do
       expect {
         casa_case.add_emancipation_category(emancipation_category.id)
       }.to change { casa_case.emancipation_categories.count }.from(0).to(1)
@@ -241,7 +241,7 @@
     let(:emancipation_option_a) { create(:emancipation_option, emancipation_category: emancipation_category) }
     let(:emancipation_option_b) { create(:emancipation_option, emancipation_category: emancipation_category, name: "Not the same name as option A to satisfy unique contraints") }
 
-    it "associates an emacipation option with the case when passed the id of the option" do
+    it "associates an emancipation option with the case when passed the id of the option" do
       expect {
         casa_case.add_emancipation_option(emancipation_option_a.id)
       }.to change { casa_case.emancipation_options.count }.from(0).to(1)

spec/models/case_assignment_spec.rb

@@ -1,14 +1,14 @@
 require "rails_helper"
 
 RSpec.describe CaseAssignment, type: :model do
-  let(:casa_org_1) { build(:casa_org) }
+  let(:casa_org_1) { create(:casa_org) }
   let(:casa_case_1) { create(:casa_case, casa_org: casa_org_1) }
   let(:volunteer_1) { create(:volunteer, casa_org: casa_org_1) }
-  let(:inactive) { build(:volunteer, :inactive, casa_org: casa_org_1) }
-  let(:supervisor) { build(:supervisor, casa_org: casa_org_1) }
-  let(:casa_case_2) { build(:casa_case, casa_org: casa_org_1) }
-  let(:volunteer_2) { build(:volunteer, casa_org: casa_org_1) }
-  let(:casa_org_2) { build(:casa_org) }
+  let(:inactive) { create(:volunteer, :inactive, casa_org: casa_org_1) }
+  let(:supervisor) { create(:supervisor, casa_org: casa_org_1) }
+  let(:casa_case_2) { create(:casa_case, casa_org: casa_org_1) }
+  let(:volunteer_2) { create(:volunteer, casa_org: casa_org_1) }
+  let(:casa_org_2) { create(:casa_org) }
 
   it "only allow active volunteers to be assigned" do
     expect(casa_case_1.case_assignments.new(volunteer: volunteer_1)).to be_valid
@@ -52,8 +52,8 @@
 
   describe ".active" do
     it "only includes active case assignments" do
-      casa_case = build(:casa_case)
-      case_assignments = 2.times.map { create(:case_assignment, casa_case: casa_case, volunteer: build(:volunteer, casa_org: casa_case.casa_org)) }
+      casa_case = create(:casa_case)
+      case_assignments = 2.times.map { create(:case_assignment, casa_case: casa_case, volunteer: create(:volunteer, casa_org: casa_case.casa_org)) }
       expect(CaseAssignment.active).to match_array(case_assignments)
 
       case_assignments.first.update(active: false)

spec/models/case_contact_spec.rb

@@ -38,17 +38,15 @@
     end
 
     it "verifies occurred at is not in the future" do
-      case_contact = build_stubbed(:case_contact, occurred_at: Time.now + 1.week)
+      case_contact = build_stubbed(:case_contact, occurred_at: Time.current + 1.week)
       expect(case_contact).not_to be_valid
       expect(case_contact.errors[:occurred_at]).to eq(["can't be in the future"])
-      expect(case_contact.errors.full_messages).to include("Date can't be in the future")
     end
 
     it "verifies occurred at is not before 1/1/1989" do
       case_contact = build_stubbed(:case_contact, occurred_at: "1984-01-01".to_date)
       expect(case_contact).not_to be_valid
       expect(case_contact.errors[:occurred_at]).to eq(["can't be prior to 01/01/1989."])
-      expect(case_contact.errors.full_messages).to include("Date can't be prior to 01/01/1989.")
     end
 
     it "validates want_driving_reimbursement can be true when miles_driven is positive" do
@@ -120,7 +118,6 @@
     it "requires occurred at" do
       case_contact = build_stubbed(:case_contact, :details_status, occurred_at: nil)
       expect(case_contact).not_to be_valid
-      expect(case_contact.errors[:occurred_at]).to eq(["can't be blank"])
       expect(case_contact.errors.full_messages).to include("Date can't be blank")
     end
 

spec/models/mileage_rate_spec.rb

@@ -22,25 +22,25 @@
 
   describe "#effective_date" do
     it "cannot be before 1/1/1989" do
-      mileage_rate = build_stubbed(:mileage_rate, effective_date: "1984-01-01".to_date)
+      mileage_rate = build(:mileage_rate, effective_date: "1984-01-01".to_date)
       expect(mileage_rate).not_to be_valid
       expect(mileage_rate.errors[:effective_date]).to eq(["cannot be prior to 1/1/1989."])
     end
 
     it "cannot be more than one year in the future" do
-      mileage_rate = build_stubbed(:mileage_rate, effective_date: 367.days.from_now)
+      mileage_rate = build(:mileage_rate, effective_date: 367.days.from_now)
       expect(mileage_rate).not_to be_valid
       expect(mileage_rate.errors[:effective_date]).to eq(["must not be more than one year in the future."])
     end
 
     it "is valid in the past after 1/1/1989" do
-      mileage_rate = build_stubbed(:mileage_rate, effective_date: "1997-08-29".to_date)
+      mileage_rate = build(:mileage_rate, effective_date: "1997-08-29".to_date)
       expect(mileage_rate).to be_valid
       expect(mileage_rate.errors[:effective_date]).to eq([])
     end
 
     it "is valid today" do
-      mileage_rate = build_stubbed(:mileage_rate, effective_date: DateTime.now)
+      mileage_rate = build(:mileage_rate, effective_date: Time.current)
       expect(mileage_rate).to be_valid
       expect(mileage_rate.errors[:effective_date]).to eq([])
     end

spec/models/placement_spec.rb

@@ -9,25 +9,25 @@
 
   context "placement_started_at" do
     it "cannot be before 1/1/1989" do
-      placement = build_stubbed(:placement, placement_started_at: "1984-01-01".to_date)
+      placement = build(:placement, placement_started_at: "1984-01-01".to_date)
       expect(placement).not_to be_valid
       expect(placement.errors[:placement_started_at]).to eq(["cannot be prior to 1/1/1989."])
     end
 
     it "cannot be more than one year in the future" do
-      placement = build_stubbed(:placement, placement_started_at: 367.days.from_now)
+      placement = build(:placement, placement_started_at: 367.days.from_now)
       expect(placement).not_to be_valid
       expect(placement.errors[:placement_started_at]).to eq(["must not be more than one year in the future."])
     end
 
     it "is valid in the past after 1/1/1989" do
-      placement = build_stubbed(:placement, placement_started_at: "1997-08-29".to_date)
+      placement = build(:placement, placement_started_at: "1997-08-29".to_date)
       expect(placement).to be_valid
       expect(placement.errors[:placement_started_at]).to eq([])
     end
 
     it "is valid today" do
-      placement = build_stubbed(:placement, placement_started_at: DateTime.now)
+      placement = build(:placement, placement_started_at: Time.current)
       expect(placement).to be_valid
       expect(placement.errors[:placement_started_at]).to eq([])
     end

spec/models/user_spec.rb

@@ -98,8 +98,8 @@
     end
 
     it "does not return case_contacts neither unassigned cases or inactive cases" do
-      inactive_case_assignment = build_stubbed(:case_assignment, casa_case: build_stubbed(:casa_case, casa_org: volunteer.casa_org), active: false, volunteer: volunteer)
-      case_assignment_to_inactve_case = build_stubbed(:case_assignment, casa_case: build_stubbed(:casa_case, active: false, casa_org: volunteer.casa_org), volunteer: volunteer)
+      inactive_case_assignment = create(:case_assignment, casa_case: create(:casa_case, casa_org: volunteer.casa_org), active: false, volunteer: volunteer)
+      case_assignment_to_inactve_case = create(:case_assignment, casa_case: create(:casa_case, active: false, casa_org: volunteer.casa_org), volunteer: volunteer)
 
       expect {
         volunteer.case_contacts_for(inactive_case_assignment.casa_case.id)
@@ -133,8 +133,8 @@
 
       it "ignores volunteers' inactive and unassgined cases" do
         volunteer = create(:volunteer, supervisor: supervisor, casa_org: casa_org)
-        build_stubbed(:case_assignment, casa_case: build_stubbed(:casa_case, casa_org: casa_org, active: false), volunteer: volunteer)
-        build_stubbed(:case_assignment, casa_case: build_stubbed(:casa_case, casa_org: casa_org), active: false, volunteer: volunteer)
+        create(:case_assignment, casa_case: create(:casa_case, casa_org: casa_org, active: false), volunteer: volunteer)
+        create(:case_assignment, casa_case: create(:casa_case, casa_org: casa_org), active: false, volunteer: volunteer)
 
         expect(supervisor.volunteers_serving_transition_aged_youth).to eq(0)
       end
@@ -168,7 +168,7 @@
       end
 
       it "returns zero for a volunteer that is not assigned to any casa cases" do
-        build_stubbed(:volunteer, supervisor: supervisor)
+        create(:volunteer, supervisor: supervisor)
         expect(supervisor.no_attempt_for_two_weeks).to eq(0)
       end
 
@@ -177,7 +177,7 @@
 
         case_of_interest_1 = volunteer_1.casa_cases.first
 
-        build_stubbed(:case_contact, creator: volunteer_1, casa_case: case_of_interest_1, contact_made: true, created_at: 3.weeks.ago)
+        create(:case_contact, creator: volunteer_1, casa_case: case_of_interest_1, contact_made: true, created_at: 3.weeks.ago)
         expect(supervisor.no_attempt_for_two_weeks).to eq(1)
       end
 
@@ -198,16 +198,16 @@
 
   describe "#active_for_authentication?" do
     it "is false when the user is inactive" do
-      user = build_stubbed(:volunteer, :inactive)
+      user = build(:volunteer, :inactive)
       expect(user).not_to be_active_for_authentication
       expect(user.inactive_message).to eq(:inactive)
     end
 
     it "is true otherwise" do
-      user = build_stubbed(:volunteer)
+      user = build(:volunteer)
       expect(user).to be_active_for_authentication
 
-      user = build_stubbed(:supervisor)
+      user = build(:supervisor)
       expect(user).to be_active_for_authentication
     end
   end
@@ -235,12 +235,12 @@
   describe "#serving_transition_aged_youth?" do
     let(:user) { build(:volunteer) }
     let!(:case_assignment_without_transition_aged_youth) do
-      build(:case_assignment, casa_case: build_stubbed(:casa_case, :pre_transition, casa_org: user.casa_org), volunteer: user)
+      create(:case_assignment, casa_case: create(:casa_case, :pre_transition, casa_org: user.casa_org), volunteer: user)
     end
 
     context "when the user has a transition-aged-youth case" do
       it "is true" do
-        create(:case_assignment, casa_case: build(:casa_case, casa_org: user.casa_org), volunteer: user)
+        create(:case_assignment, casa_case: create(:casa_case, casa_org: user.casa_org), volunteer: user)
         expect(user).to be_serving_transition_aged_youth
       end
     end
@@ -253,15 +253,15 @@
 
     context "when the user's only transition-aged-youth case is inactive" do
       it "is false" do
-        build(:case_assignment, casa_case: build_stubbed(:casa_case, casa_org: user.casa_org, active: false), volunteer: user)
+        create(:case_assignment, casa_case: create(:casa_case, casa_org: user.casa_org, active: false), volunteer: user)
 
         expect(user).not_to be_serving_transition_aged_youth
       end
     end
 
     context "when the user is unassigned from a transition-aged-youth case" do
       it "is false" do
-        build(:case_assignment, casa_case: build_stubbed(:casa_case, casa_org: user.casa_org), volunteer: user, active: false)
+        create(:case_assignment, casa_case: create(:casa_case, casa_org: user.casa_org), volunteer: user, active: false)
 
         expect(user).not_to be_serving_transition_aged_youth
       end

spec/models/volunteer_spec.rb

@@ -25,9 +25,9 @@
     let(:case_assignment5) { build(:case_assignment, casa_org: casa_org_twilio_disabled, casa_case: casa_case5) }
 
     let!(:v1) { create(:volunteer, casa_org: casa_org, case_assignments: [case_assignment1, case_assignment2, case_assignment3]) }
-    let!(:v2) { build_stubbed(:volunteer, casa_org: casa_org, active: false) }
-    let!(:v3) { build_stubbed(:volunteer, casa_org: casa_org) }
-    let!(:v4) { build_stubbed(:volunteer, casa_org: casa_org, case_assignments: [case_assignment_unassigned]) }
+    let!(:v2) { create(:volunteer, casa_org: casa_org, active: false) }
+    let!(:v3) { create(:volunteer, casa_org: casa_org) }
+    let!(:v4) { create(:volunteer, casa_org: casa_org, case_assignments: [case_assignment_unassigned]) }
     let!(:v5) { create(:volunteer, casa_org: casa_org_twilio_disabled, case_assignments: [case_assignment5]) }
 
     before do
@@ -205,18 +205,18 @@
 
     context "when a volunteer has only an inactive case where contact was not made recently" do
       it "returns true" do
-        inactive_case = build_stubbed(:casa_case, casa_org: volunteer.casa_org, active: false)
-        build_stubbed(:case_assignment, casa_case: inactive_case, volunteer: volunteer)
-        build_stubbed(:case_contact, casa_case: inactive_case, creator: volunteer, occurred_at: Date.current - 60.days, contact_made: true)
+        inactive_case = create(:casa_case, casa_org: volunteer.casa_org, active: false)
+        create(:case_assignment, casa_case: inactive_case, volunteer: volunteer)
+        create(:case_contact, casa_case: inactive_case, creator: volunteer, occurred_at: Date.current - 60.days, contact_made: true)
 
         expect(volunteer.made_contact_with_all_cases_in_days?).to eq(true)
       end
     end
 
     context "when a volunteer has only an unassigned case where contact was not made recently" do
       it "returns true" do
-        build_stubbed(:case_assignment, casa_case: casa_case, volunteer: volunteer, active: false)
-        build_stubbed(:case_contact, casa_case: casa_case, creator: volunteer, occurred_at: Date.current - 60.days, contact_made: true)
+        create(:case_assignment, casa_case: casa_case, volunteer: volunteer, active: false)
+        create(:case_contact, casa_case: casa_case, creator: volunteer, occurred_at: Date.current - 60.days, contact_made: true)
 
         expect(volunteer.made_contact_with_all_cases_in_days?).to eq(true)
       end
@@ -225,15 +225,15 @@
 
   describe "#supervised_by?" do
     it "is supervised by the currently active supervisor" do
-      supervisor = build_stubbed :supervisor
-      volunteer = build_stubbed :volunteer, supervisor: supervisor
+      supervisor = create :supervisor
+      volunteer = create :volunteer, supervisor: supervisor
 
       expect(volunteer).to be_supervised_by(supervisor)
     end
 
     it "is not supervised by supervisors that have never supervised the volunteer before" do
-      supervisor = build_stubbed :supervisor
-      volunteer = build_stubbed :volunteer
+      supervisor = create :supervisor
+      volunteer = create :volunteer
 
       expect(volunteer).not_to be_supervised_by(supervisor)
     end
@@ -251,7 +251,7 @@
   end
 
   describe "#role" do
-    subject(:volunteer) { build_stubbed :volunteer }
+    subject(:volunteer) { build :volunteer }
 
     it { expect(volunteer.role).to eq "Volunteer" }
   end
@@ -271,15 +271,15 @@
       let!(:unassigned1) { create(:volunteer, display_name: "aaa", casa_org: casa_org) }
       let!(:unassigned2) { create(:volunteer, display_name: "bbb", casa_org: casa_org) }
       let!(:unassigned_inactive) { create(:volunteer, display_name: "unassigned inactive", casa_org: casa_org, active: false) }
-      let!(:different_org) { build(:casa_org) }
-      let!(:unassigned2_different_org) { build(:volunteer, display_name: "ccc", casa_org: different_org) }
-      let!(:assigned1) { build(:volunteer, display_name: "ddd", casa_org: casa_org) }
+      let!(:different_org) { create(:casa_org) }
+      let!(:unassigned2_different_org) { create(:volunteer, display_name: "ccc", casa_org: different_org) }
+      let!(:assigned1) { create(:volunteer, display_name: "ddd", casa_org: casa_org) }
       let!(:supervisor) { create(:supervisor, display_name: "supe", casa_org: casa_org) }
       let!(:assignment1) { create(:supervisor_volunteer, volunteer: assigned1, supervisor: supervisor) }
       let!(:assigned2_different_org) { assignment1.volunteer }
-      let!(:unassigned_inactive_volunteer) { build(:volunteer, display_name: "eee", casa_org: casa_org, active: false) }
+      let!(:unassigned_inactive_volunteer) { create(:volunteer, display_name: "eee", casa_org: casa_org, active: false) }
       let!(:previously_assigned) { create(:volunteer, display_name: "fff", casa_org: casa_org) }
-      let!(:inactive_assignment) { build(:supervisor_volunteer, volunteer: previously_assigned, is_active: false, supervisor: supervisor) }
+      let!(:inactive_assignment) { create(:supervisor_volunteer, volunteer: previously_assigned, is_active: false, supervisor: supervisor) }
 
       it "returns unassigned volunteers" do
         expect(subject.map(&:display_name).sort).to eq ["aaa", "bbb", "fff"]