Check what user sees first before checking DB assertions

When github's free CI servers are under heavy load, a race condition
between the page loading and checking the database causes tests to flake.
This is caused by a system test inputting data into a form then
immediately checking the database without waiting for the form to finish submitting.

For every database check in the system files, make sure it's preceded
by a capybara matcher with automatic waiting or replace the database
check with a check for something to appear on the page.

Author: stefannibrasil

spec/system/devise/passwords/new_spec.rb

@@ -45,21 +45,28 @@
     it "sends user email" do
       fill_in "Email", with: user.email
 
-      expect { click_on "Send me reset password instructions" }.to change { ActionMailer::Base.deliveries.count }.by(1)
-      expect(ActionMailer::Base.deliveries.last.to_addresses.map(&:address)).to include user.email
+      click_on "Send me reset password instructions"
+
+      expect(page).to have_content "If the account exists you will receive an email or SMS with instructions on how to reset your password in a few minutes."
+
+      expect(ActionMailer::Base.deliveries.count).to eq(1)
+      expect(ActionMailer::Base.deliveries.last.to).to eq([user.email])
     end
 
     it "has reset password url with token" do
       fill_in "Email", with: user.email
       click_on "Send me reset password instructions"
 
+      expect(page).to have_content "If the account exists you will receive an email or SMS with instructions on how to reset your password in a few minutes."
       expect(reset_password_link(user.email)).to match(/http:\/\/localhost:3000\/users\/password\/edit\?reset_password_token=.*/)
     end
 
     it "url token matches user's encrypted token" do
       fill_in "Email", with: user.email
       click_on "Send me reset password instructions"
 
+      expect(page).to have_content "If the account exists you will receive an email or SMS with instructions on how to reset your password in a few minutes."
+
       token = reset_password_link(user.email).gsub("http://localhost:3000/users/password/edit?reset_password_token=", "")
       encrypted_token = Devise.token_generator.digest(User, :reset_password_token, token)
       expect(User.find_by(reset_password_token: encrypted_token)).not_to be_nil
@@ -80,6 +87,7 @@
       click_on "Log In"
 
       expect(page).to have_text(user.display_name)
+      expect(page).to have_text("My Cases")
       expect(page).not_to have_text("Sign in")
     end
   end