Skip to content

Commit fb55e24

Browse files
committed
fix: flake due to waiting for jobs
1 parent 46a1671 commit fb55e24

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

spec/system/casa_cases/edit_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,13 +243,13 @@
243243
# uncheck all contact type options
244244
select_all_el.click
245245
within ".ts-dropdown-content" do
246-
expect(page).to_not have_css(".form-check-input--checked")
246+
expect(page).not_to have_css(".form-check-input--checked")
247247
expect(page).to have_css(".form-check-input--unchecked", count: 2)
248248
end
249249
# check all contact type options
250250
select_all_el.click
251251
within ".ts-dropdown-content" do
252-
expect(page).to_not have_css("input.form-check-input--unchecked")
252+
expect(page).not_to have_css("input.form-check-input--unchecked")
253253
expect(page).to have_css("input.form-check-input--checked", count: 2)
254254
end
255255
# since all contact type options checked, don't need to select one

spec/system/case_contacts/followups/resolve_spec.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
require "rails_helper"
22

33
RSpec.describe "followups/resolve", :js, type: :system do
4+
include ActiveJob::TestHelper
5+
46
let(:casa_org) { create(:casa_org) }
57
let(:admin) { create(:casa_admin, casa_org: casa_org) }
68
let(:supervisor) { build(:supervisor, casa_org: casa_org) }
@@ -15,7 +17,7 @@
1517
sign_in admin
1618
visit casa_case_path(case_contact.casa_case)
1719

18-
click_button "Resolve Reminder"
20+
perform_enqueued_jobs { click_button "Resolve Reminder" }
1921

2022
expect(case_contact.followups.count).to eq(1)
2123
expect(case_contact.followups.first.resolved?).to be_truthy
@@ -39,7 +41,7 @@
3941
sign_in admin
4042
visit casa_case_path(case_contact.casa_case)
4143

42-
click_button "Resolve Reminder"
44+
perform_enqueued_jobs { click_button "Resolve Reminder" }
4345

4446
expect(page).to have_button("Make Reminder")
4547
end
@@ -53,7 +55,7 @@
5355
sign_in supervisor
5456
visit casa_case_path(case_contact.casa_case)
5557

56-
click_button "Resolve Reminder"
58+
perform_enqueued_jobs { click_button "Resolve Reminder" }
5759

5860
expect(case_contact.followups.count).to eq(1)
5961
expect(case_contact.followups.first.resolved?).to be_truthy
@@ -72,7 +74,7 @@
7274
sign_in volunteer
7375
visit case_contacts_path
7476

75-
click_button "Resolve Reminder"
77+
perform_enqueued_jobs { click_button "Resolve Reminder" }
7678

7779
expect(case_contact.followups.count).to eq(1)
7880
expect(case_contact.followups.first.resolved?).to be_truthy

0 commit comments

Comments
 (0)