Explicit text values and check for what user sees in the page

Closes #6329

- fixes one factory creation (it was creating admin twice)
- checks for explicit values in the page
- avoids checking the database for changes, and
  checks for what the user sees when interacting with
  the page

Author: stefannibrasil

spec/system/court_dates/edit_spec.rb

@@ -4,29 +4,28 @@
 
 RSpec.describe "court_dates/edit", type: :system do
   context "with date"
-  let(:now) { Date.new(2021, 1, 1) }
   let(:organization) { create(:casa_org) }
   let(:admin) { create(:casa_admin, casa_org: organization) }
   let(:volunteer) { create(:volunteer) }
-  let(:supervisor) { create(:casa_admin, casa_org: organization) }
-  let!(:casa_case) { create(:casa_case, casa_org: organization) }
-  let!(:court_date) { create(:court_date, :with_court_details, casa_case: casa_case, date: now - 1.week) }
-  let!(:future_court_date) { create(:court_date, :with_court_details, casa_case: casa_case, date: now + 1.week) }
+  let(:supervisor) { create(:supervisor, casa_org: organization) }
+  let!(:casa_case) { create(:casa_case, case_number: 'CINA-08-1001', casa_org: organization) }
+  let!(:past_court_date) { create(:court_date, :with_court_details, casa_case: casa_case, date: Date.new(2020, 12, 25)) }
+  let!(:future_court_date) { create(:court_date, :with_court_details, casa_case: casa_case, date: Date.new(2021, 1, 8)) }
 
   before do
-    travel_to now
+    travel_to(Date.new(2021, 1, 1))
   end
 
   context "as an admin" do
     before do
       sign_in admin
       visit casa_case_path(casa_case)
-      click_on court_date.date.strftime("%B %-d, %Y")
+      click_on "December 25, 2020"
       click_on "Edit"
     end
 
     it "shows court orders" do
-      court_order = court_date.case_court_orders.first
+      court_order = past_court_date.case_court_orders.first
 
       expect(page).to have_text(court_order.text)
       expect(page).to have_text(court_order.implementation_status.humanize)
@@ -50,7 +49,7 @@
     it "edits past court date", :js do
       expect(page).to have_text("Editing Court Date")
       expect(page).to have_text("Case Number:")
-      expect(page).to have_text(casa_case.case_number)
+      expect(page).to have_text('CINA-08-1001')
       expect(page).to have_text("Add Court Date")
       expect(page).to have_field("court_date_date", with: "2020-12-25")
       expect(page).to have_text("Add Court Report Due Date")
@@ -66,41 +65,48 @@
       within ".top-page-actions" do
         click_on "Update"
       end
+
       expect(page).to have_text("Court Order Text One")
     end
 
-    it "can delete a future court date", :js do
+    it "allows deleting a future court date", :js do
       visit root_path
       click_on "Cases"
-      click_on casa_case.case_number
+      click_on 'CINA-08-1001'
+
+      expect(page).to have_content("December 25, 2020")
+      expect(page).to have_content("January 8, 2021")
 
-      expect(CourtDate.count).to eq 2
-      expect(page).to have_content future_court_date.date.strftime("%B %-d, %Y")
-      page.find("a", text: future_court_date.date.strftime("%B %-d, %Y")).click
+      page.find("a", text: "January 8, 2021").click
       accept_alert "Are you sure?" do
         page.find("a", text: "Delete Future Court Date").click
       end
       expect(page).to have_content "Court date was successfully deleted"
-      expect(CourtDate.count).to eq 1
+
+      expect(page).not_to have_content("January 8, 2021")
+      expect(page).to have_content("December 25, 2020")
     end
   end
 
   context "as a supervisor" do
-    it "can delete a future court date", :js do
+    it "allows deleting a future court date", :js do
       sign_in supervisor
 
       visit root_path
       click_on "Cases"
-      click_on casa_case.case_number
+      click_on 'CINA-08-1001'
 
-      expect(CourtDate.count).to eq 2
-      expect(page).to have_content future_court_date.date.strftime("%B %-d, %Y")
-      page.find("a", text: future_court_date.date.strftime("%B %-d, %Y")).click
-      page.find("a", text: "Delete Future Court Date").click
-      page.driver.browser.switch_to.alert.accept
+      expect(page).to have_content("December 25, 2020")
+      expect(page).to have_content("January 8, 2021")
+
+      page.find("a", text: "January 8, 2021").click
+      accept_alert "Are you sure?" do
+        page.find("a", text: "Delete Future Court Date").click
+      end
 
       expect(page).to have_content "Court date was successfully deleted."
-      expect(CourtDate.count).to eq 1
+      expect(page).not_to have_content("January 8, 2021")
+      expect(page).to have_content("December 25, 2020")
     end
   end
 
@@ -111,11 +117,13 @@
 
       visit root_path
       click_on "Cases"
-      click_on casa_case.case_number
+      click_on 'CINA-08-1001'
+
+      expect(page).to have_content("December 25, 2020")
+      expect(page).to have_content("January 8, 2021")
+
+      page.find("a", text: "January 8, 2021").click
 
-      expect(CourtDate.count).to eq 2
-      expect(page).to have_content future_court_date.date.strftime("%B %-d, %Y")
-      page.find("a", text: future_court_date.date.strftime("%B %-d, %Y")).click
       expect(page).not_to have_content "Delete Future Court Date"
     end
   end