Skip to content

Wait for page load before database load#6305

Merged
FireLemons merged 1 commit intorubyforgood:mainfrom
dmcarmo:fix-race-condition-system-tests
Apr 2, 2025
Merged

Wait for page load before database load#6305
FireLemons merged 1 commit intorubyforgood:mainfrom
dmcarmo:fix-race-condition-system-tests

Conversation

@dmcarmo
Copy link
Copy Markdown
Contributor

@dmcarmo dmcarmo commented Apr 2, 2025

What changed, and why?

  • Check for the database update after the page is loaded to avoid race condition.
  • Also deleted optional filling out of form fields
complete_notes_page
  • removed
      click_on "Submit"
      expect(case_contact.reload.volunteer_address).to be_blank

because the steps were irrelevant to the test

@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Apr 2, 2025
@FireLemons FireLemons merged commit 5a52ad1 into rubyforgood:main Apr 2, 2025
12 checks passed
This was referenced Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code Tests! 🎉💖👏

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants