Fix #6404: Trim whitespace from custom link text before saving#6405
Merged
compwron merged 3 commits intorubyforgood:mainfrom May 28, 2025
Merged
Conversation
nizam12khan
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
compwron
reviewed
May 28, 2025
| private | ||
|
|
||
| def trim_name | ||
| self.text = text.strip if text.present? |
Collaborator
There was a problem hiding this comment.
I would like a spec to go with this change, as with all changes. Can you add a spec in a follow up PR? Thanks in advance! :)
Contributor
Author
There was a problem hiding this comment.
I have raised a follow up PR with specs #6407 , Kindly review it! Thanks!
compwron
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6404
before_savecallback inCustomOrgLinkto trim whitespace from thetextfield before saving.CustomOrgLinkrecords (please review if this is desired). Usedup/downmethods since this is a data migration and not reversible. Tested locally to confirm it works.