Race condition check: index volunteers system spec#6748
Merged
FireLemons merged 1 commit intorubyforgood:mainfrom Mar 7, 2026
Merged
Race condition check: index volunteers system spec#6748FireLemons merged 1 commit intorubyforgood:mainfrom
FireLemons merged 1 commit intorubyforgood:mainfrom
Conversation
In terms of hitting the database, this test wasn't that bad. But since I was reviewing it, I found these low hanging fruits to improve: Assigning a volunteer to a supervisor seems to be enough, and doing that avoids creating unnecessary associations when using the `with_assigned_supervisor` trait. Additionally, creating records when building is possible, creating fewer records, and reusing the same supervisor factory keeps the test setup faster.
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
5 tasks
Collaborator
|
🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Related #6698
What changed, and why?
In terms of hitting the database, this test wasn't that bad. But since I was reviewing it, I found these low hanging fruits to improve:
with_assigned_supervisortrait. Assigning a supervisor to a volunteer creates fewer associations.How is this tested? (please write rspec and jest tests!) 💖💪
Everything is tests ⭐