Skip to content

Race condition check: index volunteers system spec #6748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FireLemons merged 1 commit into from
Mar 7, 2026
Merged

Race condition check: index volunteers system spec #6748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 17 additions & 37 deletions spec/system/volunteers/index_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
RSpec.describe "view all volunteers", :js, type: :system do
let(:organization) { create(:casa_org) }
let(:admin) { create(:casa_admin, casa_org: organization) }
let!(:supervisor) { create(:supervisor, casa_org: organization) }

context "admin user" do
context "when no logo_url" do
it "can see volunteers and navigate to their cases", :js do
volunteer = create(:volunteer, :with_assigned_supervisor, display_name: "User 1", email: "casa@example.com", casa_org: organization)
volunteer.casa_cases << create(:casa_case, casa_org: organization, birth_month_year_youth: CasaCase::TRANSITION_AGE.years.ago)
volunteer.casa_cases << create(:casa_case, casa_org: organization, birth_month_year_youth: CasaCase::TRANSITION_AGE.years.ago)
volunteer = create(:volunteer, display_name: "User 1", email: "casa@example.com", casa_org: organization, supervisor: supervisor)
volunteer.casa_cases << build(:casa_case, casa_org: organization, birth_month_year_youth: CasaCase::TRANSITION_AGE.years.ago)
volunteer.casa_cases << build(:casa_case, casa_org: organization, birth_month_year_youth: CasaCase::TRANSITION_AGE.years.ago)
casa_case = volunteer.casa_cases[0]

sign_in admin
Expand Down Expand Up @@ -42,7 +43,7 @@
end

it "displays last attempted contact by default", :js do
create(:volunteer, :with_assigned_supervisor, display_name: "User 1", email: "casa@example.com", casa_org: organization)
create(:volunteer, display_name: "User 1", email: "casa@example.com", casa_org: organization, supervisor: supervisor)

sign_in admin

Expand Down Expand Up @@ -79,9 +80,9 @@
end

it "can filter volunteers", :js do
assigned_volunteers = create_list(:volunteer, 3, :with_assigned_supervisor, casa_org: organization)
assigned_volunteers = create_list(:volunteer, 2, casa_org: organization, supervisor: supervisor)
inactive_volunteers = create_list(:volunteer, 2, :inactive, casa_org: organization)
unassigned_volunteers = create_list(:volunteer, 1, casa_org: organization)
unassigned_volunteer = create(:volunteer, casa_org: organization)

sign_in admin

Expand All @@ -91,9 +92,7 @@
assigned_volunteers.each do |assigned_volunteer|
expect(page).to have_text assigned_volunteer.display_name
end
unassigned_volunteers.each do |unassigned_volunteer|
expect(page).to have_text unassigned_volunteer.display_name
end
expect(page).to have_text unassigned_volunteer.display_name

click_on "Status"
find(:css, 'input[data-value="true"]').set(false)
Expand All @@ -115,7 +114,7 @@
end

it "can go to the volunteer edit page from the volunteer list", :js do
create(:volunteer, :with_assigned_supervisor, casa_org: organization)
create(:volunteer, casa_org: organization, supervisor: supervisor)
sign_in admin

visit volunteers_path
Expand Down Expand Up @@ -172,38 +171,33 @@
end
end

# These tests are very flaky do to the use of datatables on this page.
# If the page is switched over to Hotwire, should try to re-instate these tests.
describe "Manage Volunteers button" do
let!(:volunteers) { create_list(:volunteer, 3, casa_org: organization) }
let!(:volunteers) { create_list(:volunteer, 2, casa_org: organization) }

before do
sign_in admin
visit volunteers_path
end

it "does not display by default" do
visit volunteers_path
expect(page).to have_no_text "Manage Volunteer"
end

context "when one or more volunteers selected" do
it "is displayed" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteers[0].id}").click

expect(page).to have_text "Manage Volunteer"
end

it "displays number of volunteers selected" do
visit volunteers_path
volunteers.each_with_index do |volunteer, index|
find("#supervisor_volunteer_volunteer_ids_#{volunteer.id}").click
expect(page).to have_css("[data-select-all-target='buttonLabel']", text: "#{index + 1})")
end
end

it "text matches pluralization of volunteers selected" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteers[0].id}").click
expect(page).to have_no_text "Manage Volunteers"

Expand All @@ -212,7 +206,6 @@
end

it "is hidden when all volunteers unchecked" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteers[0].id}").click
expect(page).to have_text "Manage Volunteer"

Expand All @@ -223,14 +216,14 @@
end

describe "Select All Checkbox" do
let!(:volunteers) { create_list(:volunteer, 3, casa_org: organization) }
let!(:volunteers) { create_list(:volunteer, 2, casa_org: organization) }

before do
sign_in admin
visit volunteers_path
end

it "selects all volunteers" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteers[0].id}") # Wait for data table to be loaded
find_by_id("checkbox-toggle-all").click

Expand All @@ -241,7 +234,6 @@

context "when all are checked" do
it "deselects all volunteers" do
visit volunteers_path
volunteers.each do |volunteer|
find("#supervisor_volunteer_volunteer_ids_#{volunteer.id}").click
end
Expand All @@ -257,15 +249,13 @@

context "when some are checked" do
it "is semi-checked (indeterminate)" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteers[0].id}").click

expect(page).to have_field("checkbox-toggle-all", checked: false)
expect(find_by_id("checkbox-toggle-all")[:indeterminate]).to eq("true")
end

it "selects all volunteers" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteers[0].id}").click
find_by_id("checkbox-toggle-all").click

Expand All @@ -278,14 +268,13 @@

describe "Select Supervisor Modal Submit button" do
let!(:volunteer) { create(:volunteer, casa_org: organization) }
let!(:supervisor) { create(:supervisor, casa_org: organization) }

before do
sign_in admin
visit volunteers_path
end

it "is disabled by default" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteer.id}").click
find("[data-select-all-target='button']").click

Expand All @@ -294,7 +283,6 @@

context "when none is selected" do
it "is enabled" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteer.id}").click
find("[data-select-all-target='button']").click
select "None", from: "supervisor_volunteer_supervisor_id"
Expand All @@ -305,7 +293,6 @@

context "when a supervisor is selected" do
it "is enabled" do
visit volunteers_path
find("#supervisor_volunteer_volunteer_ids_#{volunteer.id}").click
find("[data-select-all-target='button']").click

Expand All @@ -331,15 +318,11 @@
end

context "supervisor user" do
let(:supervisor) { create(:supervisor, casa_org: organization) }

it "can filter volunteers", :js do
active_volunteers = create_list(:volunteer, 3, :with_assigned_supervisor, casa_org: organization)
active_volunteers[2].supervisor = supervisor
active_volunteer = create(:volunteer, :with_assigned_supervisor, casa_org: organization)
active_volunteer.supervisor = supervisor

inactive_volunteers = create_list(:volunteer, 2, :with_assigned_supervisor, :inactive, casa_org: organization)
inactive_volunteers[0].supervisor = supervisor
inactive_volunteers[1].supervisor = supervisor
inactive_volunteers = create_list(:volunteer, 2, :inactive, supervisor: supervisor, casa_org: organization)

sign_in supervisor

Expand All @@ -359,7 +342,6 @@
end

it "can show/hide columns on volunteers table", :js do
travel_back
sign_in supervisor

visit volunteers_path
Expand Down Expand Up @@ -437,8 +419,6 @@
end

context "with volunteers" do
let(:supervisor) { create(:supervisor, :with_volunteers) }

it "Search history is clean after navigating away from volunteers view", :js do
sign_in supervisor
visit volunteers_path
Expand Down
Loading