Replace date string with Date object#6764
Merged
compwron merged 1 commit intorubyforgood:mainfrom Mar 11, 2026
Merged
Conversation
jyeharry
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
Contributor
Author
|
@compwron Don't think I have merge permissions :) |
stefannibrasil
added a commit
to hexdevs/casa
that referenced
this pull request
Mar 18, 2026
Resolves rubyforgood#6701 When github's free CI servers are under heavy load, a race condition between the page loading and checking the database causes tests to flake. This is caused by a system test inputting data into a form then immediately checking the database without waiting for the form to finish submitting. For every database check in the system files, this ensures it's preceded by a capybara matcher with automatic waiting, such as checking for assertions after the page loads before checking for DB values, or replaced the database check with a check for something to appear on the page. I also took the opportunity to refactor some small things to save up test setup time: - build factories instead of creating as much as possible - require `:js` only when necessary - remove unused variables and factories - keep necessary factories close to where they are used to avoid creating extra factories when not needed - update Date string to Date objects (these were flaky locally), similar to rubyforgood#6764
stefannibrasil
added a commit
to hexdevs/casa
that referenced
this pull request
Mar 18, 2026
Resolves rubyforgood#6701 When github's free CI servers are under heavy load, a race condition between the page loading and checking the database causes tests to flake. This is caused by a system test inputting data into a form then immediately checking the database without waiting for the form to finish submitting. For every database check in the system files, this ensures it's preceded by a capybara matcher with automatic waiting, such as checking for assertions after the page loads before checking for DB values, or replaced the database check with a check for something to appear on the page. I also took the opportunity to refactor some small things to save up test setup time: - build factories instead of creating as much as possible - require `:js` only when necessary - remove unused variables and factories - keep necessary factories close to where they are used to avoid creating extra factories when not needed - update Date string to Date objects (these were flaky locally), similar to rubyforgood#6764
compwron
pushed a commit
that referenced
this pull request
Mar 20, 2026
Resolves #6701 When github's free CI servers are under heavy load, a race condition between the page loading and checking the database causes tests to flake. This is caused by a system test inputting data into a form then immediately checking the database without waiting for the form to finish submitting. For every database check in the system files, this ensures it's preceded by a capybara matcher with automatic waiting, such as checking for assertions after the page loads before checking for DB values, or replaced the database check with a check for something to appear on the page. I also took the opportunity to refactor some small things to save up test setup time: - build factories instead of creating as much as possible - require `:js` only when necessary - remove unused variables and factories - keep necessary factories close to where they are used to avoid creating extra factories when not needed - update Date string to Date objects (these were flaky locally), similar to #6764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6763
What changed, and why?
Replaced a date string
"01/02/2020"with aDateobject to ensure consistent date rendering across timezones.How is this tested? (please write rspec and jest tests!) 💖💪
Updated flaky test.
Screenshots please :)
N/A