Skip to content

Race condition check: invite volunteers system spec #6766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compwron merged 4 commits into from
Mar 11, 2026
Merged

Race condition check: invite volunteers system spec #6766

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4cc3bfe
this setup is not needed
stefannibrasil Mar 11, 2026
04a8436
Remove test that is already done in unit test
stefannibrasil Mar 11, 2026
19d56c4
Check for page assertions before DB checks
stefannibrasil Mar 11, 2026
372bcb7
Trigger Build
stefannibrasil Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 12 additions & 31 deletions spec/system/volunteers/invite_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,6 @@
let(:admin) { create(:casa_admin, casa_org: organization) }

before do
# Stub the request to the URL shortener service (needed if phone is provided)
stub_request(:post, "https://api.short.io/links")
.to_return(
status: 200,
body: {shortURL: "https://short.url/example"}.to_json,
headers: {"Content-Type" => "application/json"}
)

sign_in admin
end

Expand All @@ -24,9 +16,9 @@
fill_in "Display name", with: "Jane Doe"
fill_in "Date of birth", with: Date.new(1995, 5, 15)

expect {
click_on "Create Volunteer"
}.to change(Volunteer, :count).by(1)
click_on "Create Volunteer"

expect(page).to have_selector(".notice", text: "New volunteer created successfully")

volunteer = Volunteer.find_by(email: "new_volunteer@example.com")
expect(volunteer).to be_present
Expand All @@ -49,6 +41,8 @@

click_on "Create Volunteer"

expect(page).to have_selector(".notice", text: "New volunteer created successfully")

volunteer = Volunteer.find_by(email: "volunteer_with_token@example.com")
expect(volunteer.invitation_created_at).to be_present
expect(volunteer.invitation_accepted_at).to be_nil
Expand Down Expand Up @@ -85,11 +79,11 @@

click_on "Set my password"

expect(page).to have_selector(".notice", text: "Your password was set successfully. You are now signed in")
expect(page).to have_text("My Cases")

volunteer.reload
expect(volunteer.invitation_accepted_at).not_to be_nil

# Should be redirected to dashboard after accepting invitation
expect(page).to have_text("My Cases")
end

it "shows error when passwords don't match" do
Expand Down Expand Up @@ -145,9 +139,7 @@
it "allows admin to resend invitation to volunteer who hasn't accepted" do
visit edit_volunteer_path(volunteer)

expect {
click_on "Resend Invitation"
}.to change { ActionMailer::Base.deliveries.count }.by(1)
click_on "Resend Invitation"

expect(page).to have_text "Invitation sent"

Expand Down Expand Up @@ -180,9 +172,9 @@
fill_in "Display name", with: "Supervisor's Volunteer"
fill_in "Date of birth", with: Date.new(1992, 3, 20)

expect {
click_on "Create Volunteer"
}.to change(Volunteer, :count).by(1)
click_on "Create Volunteer"

expect(page).to have_selector(".notice", text: "New volunteer created successfully")

volunteer = Volunteer.find_by(email: "supervisor_volunteer@example.com")
expect(volunteer).to be_present
Expand All @@ -208,15 +200,4 @@
expect(page).to have_selector(".alert", text: "Sorry, you are not authorized to perform this action.")
end
end

describe "invitation expiration" do
Copy link
Copy Markdown
Contributor Author

@stefannibrasil stefannibrasil Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not an integration one because there is no UI interaction. It's also covered by this unit test already: https://github.com/rubyforgood/casa/blob/main/spec/models/volunteer_spec.rb#L388

let(:volunteer) { create(:volunteer, casa_org: organization) }

it "volunteers have invitation valid for 1 year" do
volunteer.invite!(admin)

# Check that volunteer model has correct invitation period
expect(Volunteer.invite_for).to eq(1.year)
end
end
end
Loading