Race Condition Check: spec/system/volunteers/edit and notes/edit_spec.rb specs#6767
Merged
compwron merged 5 commits intorubyforgood:mainfrom Mar 11, 2026
Merged
Conversation
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
stefannibrasil
force-pushed
the
sb-volunteers-system-spec-take4-6698
branch
from
beb390b to
4afee2d
Compare
This reduces race condition issues by checking what happens in the browser first.
stefannibrasil
force-pushed
the
sb-volunteers-system-spec-take4-6698
branch
from
5df0c87 to
e420372
Compare
Contributor
Author
|
@FireLemons I made the changes you suggested yesterday at the office hours. Let me know what other suggestions you have. Thanks! |
5 tasks
compwron
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Related #6698
What changed, and why?
These tests were pretty good and have a few opportunities to reduce race condition issues. Since I was reviewing them, I took the opportunity to improve the tests by: