Skip to content

Fix flaky VolunteerPolicy spec by making org assignments explicit #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
compwron merged 1 commit into from
Mar 13, 2026
Merged

Fix flaky VolunteerPolicy spec by making org assignments explicit #6771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions spec/policies/volunteer_policy_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,15 @@
RSpec.describe VolunteerPolicy do
subject { described_class }

let(:admin) { build_stubbed(:casa_admin) }
let(:supervisor) { build_stubbed(:supervisor) }
let(:volunteer) { build_stubbed(:volunteer) }
let(:casa_org) { build_stubbed(:casa_org) }
let(:other_org) { build_stubbed(:casa_org) }
let(:admin) { build_stubbed(:casa_admin, casa_org: casa_org) }
let(:supervisor) { build_stubbed(:supervisor, casa_org: casa_org) }
let(:volunteer) { build_stubbed(:volunteer, casa_org: casa_org) }

permissions :edit? do
context "same org" do
let(:record) { build_stubbed(:volunteer, casa_org: admin.casa_org) }
let(:record) { build_stubbed(:volunteer, casa_org: casa_org) }

context "when user is a casa admin" do
it "allows for same org" do
Expand All @@ -31,7 +33,7 @@
end

context "different org" do
let(:record) { build_stubbed(:volunteer, casa_org: build_stubbed(:casa_org)) }
let(:record) { build_stubbed(:volunteer, casa_org: other_org) }

context "when user is a casa admin" do
it "does not allow for different org" do
Expand All @@ -55,15 +57,15 @@

permissions :index?, :activate?, :create?, :datatable?, :deactivate?, :new?, :show?, :update? do
context "when user is a casa admin" do
let(:record) { build_stubbed(:volunteer, casa_org: admin.casa_org) }
let(:record) { build_stubbed(:volunteer, casa_org: casa_org) }

it "allows" do
expect(subject).to permit(admin, record)
end
end

context "when user is a supervisor" do
let(:record) { build_stubbed(:volunteer, casa_org: supervisor.casa_org) }
let(:record) { build_stubbed(:volunteer, casa_org: casa_org) }

it "allows" do
expect(subject).to permit(supervisor, record)
Expand Down
Loading