Bump devise to 5.0.3 and fixes tests that need to be updated#6787
Merged
compwron merged 2 commits intorubyforgood:mainfrom Mar 18, 2026
Merged
Bump devise to 5.0.3 and fixes tests that need to be updated#6787compwron merged 2 commits intorubyforgood:mainfrom
compwron merged 2 commits intorubyforgood:mainfrom
Conversation
Fixes rubyforgood#6786 With this new version, devise errors are now lowercase. To prevent these tests to erroring out again because of uppercase changes, the text are asserted against a case insensitive regex.
stefannibrasil
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
bot
added
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the authentication stack by bumping Devise to 5.0.3 and adjusts system specs to tolerate Devise’s updated (lowercased) failure message formatting.
Changes:
- Bump
devisefrom 4.9.4 to 5.0.3 (and related dependency updates inGemfile.lock). - Update system specs to assert the “invalid email or password” flash message using a case-insensitive regex.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/system/sessions/new_spec.rb | Makes invalid-login assertion case-insensitive for Devise 5 messaging. |
| spec/system/sessions/login_spec.rb | Makes failed-login error assertion case-insensitive for Devise 5 messaging. |
| spec/system/all_casa_admins/sessions/new_spec.rb | Makes invalid-login assertion case-insensitive for Devise 5 messaging. |
| Gemfile.lock | Locks Devise 5.0.3 and updates related gem versions/constraints. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Fixes #6786
Breaking changes can be found in the Changelog: https://github.com/heartcombo/devise/blob/main/CHANGELOG.md#500rc---2025-12-31
What changed, and why?
With this new version, devise errors
are now lowercase. To prevent these tests
to erroring out again because of uppercase changes,
the text are asserted against a case insensitive
regex.