Minor request specs improvements

- reuse an existing record instead of creating
duplicate ones
- assert that the correct flash notice is displayed
when saving an audit

Author: stefannibrasil

spec/requests/audits_requests_spec.rb

@@ -6,24 +6,22 @@
     {
       organization_id: organization.id,
       storage_location_id: storage_location.id,
-      user_id: create(:organization_admin, organization: organization).id
+      user_id: organization_admin.id
     }
   end
 
   let(:invalid_storage_location_attributes) do
     {
       organization_id: organization.id,
       storage_location_id: nil,
-      user_id: create(:organization_admin, organization: organization).id
+      user_id: organization_admin.id
     }
   end
 
   let(:invalid_attributes) do
     { organization_id: nil }
   end
 
-  let(:valid_session) { {} }
-
   describe "while signed in as an organization admin" do
     before do
       sign_in(organization_admin)
@@ -155,6 +153,7 @@
           expect do
             post audits_path(audit: valid_attributes, save_progress: '')
             expect(Audit.last.in_progress?).to be_truthy
+            expect(flash[:notice]).to include("Audit's progress was successfully saved.")
           end.to change(Audit.in_progress, :count).by(1)
         end