Test the yielding not the end output

Author: jparcill

app/controllers/distributions_controller.rb

@@ -75,8 +75,8 @@ def index
     respond_to do |format|
       format.html
       format.csv do
-        send_stream filename: "Distributions-#{Time.zone.today}.csv" do |stream| 
-          Exports::ExportDistributionsCSVService.new(distributions: @distributions.includes(line_items: :item), organization: current_organization, filters: scope_filters).generate_csv_stream do |row| 
+        send_stream filename: "Distributions-#{Time.zone.today}.csv" do |stream|
+          Exports::ExportDistributionsCSVService.new(distributions: @distributions.includes(line_items: :item), organization: current_organization, filters: scope_filters).generate_csv_stream do |row|
             stream.write(row)
           end
         end

spec/services/exports/export_distributions_csv_service_spec.rb

@@ -7,11 +7,7 @@
 
   describe '#generate_csv_stream' do
     subject do
-      rows = ""
-      described_class.new(distributions: distributions, organization: organization, filters: filters).generate_csv_stream do |row|
-        rows << row
-      end
-      rows
+      Proc.new { described_class.new(distributions: distributions, organization: organization, filters: filters).generate_csv_stream }
     end
 
     let(:duplicate_item) { create(:item, name: "Dupe Item", value_in_cents: 300, organization: organization, package_size: 2) }
@@ -66,7 +62,9 @@
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 2,Disposable Diapers,0,0,2,0,0
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 3,Disposable Diapers,0,0,0,0,3
         CSV
-        expect(subject).to eq(csv)
+        subject do |subject_row|
+          expect(row).to eq(csv.next)
+        end
       end
     end
 
@@ -81,7 +79,9 @@
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 2,Disposable Diapers,0,0.00,0,0.00,2,60.00,0,0.00,0,0.00
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 3,Disposable Diapers,0,0.00,0,0.00,0,0.00,0,0.00,3,120.00
         CSV
-        expect(subject).to eq(csv)
+        subject do |subject_row|
+          expect(row).to eq(csv.next)
+        end
       end
     end
 
@@ -96,7 +96,9 @@
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 2,Disposable Diapers,0,0,0,0,2,0,0,0,0,0
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 3,Disposable Diapers,0,0,0,0,0,0,0,0,3,0
         CSV
-        expect(subject).to eq(csv)
+        subject do |subject_row|
+          expect(row).to eq(csv.next)
+        end
       end
     end
 
@@ -112,7 +114,9 @@
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 2,Disposable Diapers,0,0.00,0,0,0.00,0,2,60.00,0,0,0.00,0,0,0.00,0
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 3,Disposable Diapers,0,0.00,0,0,0.00,0,0,0.00,0,0,0.00,0,3,120.00,0
         CSV
-        expect(subject).to eq(csv)
+        subject do |subject_row|
+          expect(row).to eq(csv.next)
+        end
       end
     end
 
@@ -134,13 +138,24 @@
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 2,Disposable Diapers,0,0,2,0,0,0
           #{partner.name},04/04/2025,04/04/2025,#{storage_location.name},0,0.0,shipped,$15.01,scheduled,"",comment 3,Disposable Diapers,0,0,0,0,3,0
         CSV
-        expect(subject).to eq(csv)
+
+        subject do |subject_row|
+          expect(row).to eq(csv.next)
+        end
       end
     end
 
     context 'reporting category column' do
       let(:filters) { {} }
 
+      subject do
+        rows = ""
+        described_class.new(distributions: distributions, organization: organization, filters: filters).generate_csv_stream do |row|
+          rows << row
+        end
+        rows
+      end
+
       it 'includes a Reporting Category column with the humanized category for each distribution' do
         csv = CSV.parse(subject, headers: true)
         expect(csv.headers).to include("Reporting Category")
@@ -185,7 +200,9 @@
         csv = <<~CSV
           Partner,Initial Allocation,Scheduled for,Source Inventory,Total Number of #{item_name},Total Value of #{item_name},Delivery Method,Shipping Cost,Status,Agency Representative,Comments,Reporting Category,Dupe Item
         CSV
-        expect(subject).to eq(csv)
+        subject do |subject_row|
+          expect(row).to eq(csv.next)
+        end
       end
     end
   end