Fix 500 bug for requests export after changing item name (#5028)

* Fix 500 bug for requests export after changing item name

* Refactor test changes

Author: coalest

app/models/partners/item_request.rb

@@ -38,9 +38,9 @@ def request_unit_is_supported
 
     def name_with_unit(quantity_override = nil)
       if Flipper.enabled?(:enable_packs) && request_unit.present?
-        "#{name} - #{request_unit.pluralize(quantity_override || quantity.to_i)}"
+        "#{item.name} - #{request_unit.pluralize(quantity_override || quantity.to_i)}"
       else
-        name
+        item.name
       end
     end
   end

app/services/requests_total_items_service.rb

@@ -15,6 +15,6 @@ def calculate
   private
 
   def item_requests
-    @item_requests ||= Partners::ItemRequest.where(request: @requests)
+    @item_requests ||= Partners::ItemRequest.includes(:item).where(request: @requests)
   end
 end

spec/services/exports/export_request_service_spec.rb

@@ -84,6 +84,12 @@
            ])
   end
 
+  # Update item name after the request has been created to ensure export shows
+  # current item name.
+  before do
+    item_2t.update!(name: "2T Diapers -- UPDATED")
+  end
+
   subject do
     described_class.new(Request.all).generate_csv_data
   end
@@ -100,7 +106,7 @@
           "Requestor",
           "Type",
           "Status",
-          "2T Diapers",
+          "2T Diapers -- UPDATED",
           "3T Diapers",
           "4T Diapers",
           "4T Diapers - packs",
@@ -225,7 +231,7 @@
           "Requestor",
           "Type",
           "Status",
-          "2T Diapers",
+          "2T Diapers -- UPDATED",
           "3T Diapers",
           "4T Diapers",
           "<DELETED_ITEMS>"