feat: Add GET route for sign out on static error pages

- Add GET route for sign out in devise_scope block in routes
- Add sign_out action to sessions controller
- Add feature tests for logout on error pages
- Remove data-method="delete" from error pages

Author: Gabe-Torres

app/controllers/users/sessions_controller.rb

@@ -21,6 +21,12 @@ def create
     UsersRole.set_last_role_for(current_user, @role)
   end
 
+  # GET /resource/sign_out
+  def sign_out
+    sign_out(current_user) if user_signed_in?
+    redirect_to root_path, notice: "Signed out successfully"
+  end
+
   # DELETE /resource/sign_out
   # def destroy
   #   super

config/routes.rb

@@ -14,6 +14,10 @@ def set_up_flipper
     omniauth_callbacks: 'users/omniauth_callbacks'
   }
 
+  devise_scope :user do
+    get 'users/sign_out', to: 'users/sessions#sign_out', as: :user_sign_out
+  end
+
   #
   # Mount web interface to see delayed job status and queue length.
   # Visible only to logged in users with the `super_admin` role

public/403.html

@@ -34,7 +34,7 @@
         <div class="navbar-custom-menu">
           <ul class="nav navbar-nav">
             <li class="user user-menu">
-              <a rel="nofollow" class=" btn btn-danger btn-md  " data-method="delete" href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
+              <a rel="nofollow" class=" btn btn-danger btn-md  " href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
             </li>
           </ul>
         </div>

public/404.html

@@ -35,7 +35,7 @@
         <div class="navbar-custom-menu">
           <ul class="nav navbar-nav">
             <li class="user user-menu">
-              <a rel="nofollow" class=" btn btn-danger btn-md  " data-method="delete" href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
+              <a rel="nofollow" class=" btn btn-danger btn-md  " href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
             </li>
           </ul>
         </div>

public/422.html

@@ -33,7 +33,7 @@
         <div class="navbar-custom-menu">
           <ul class="nav navbar-nav">
             <li class="user user-menu">
-              <a rel="nofollow" class=" btn btn-danger btn-md  " data-method="delete" href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
+              <a rel="nofollow" class=" btn btn-danger btn-md  " href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
             </li>
           </ul>
         </div>

public/500.html

@@ -33,7 +33,7 @@
         <div class="navbar-custom-menu">
           <ul class="nav navbar-nav">
             <li class="user user-menu">
-              <a rel="nofollow" class=" btn btn-danger btn-md  " data-method="delete" href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
+              <a rel="nofollow" class=" btn btn-danger btn-md  " href="/users/sign_out"><i class="fa fa-sign-out"></i> Log out</a>
             </li>
           </ul>
         </div>

spec/features/error_pages_spec.rb

@@ -0,0 +1,49 @@
+require "rails_helper"
+
+RSpec.describe "Error Pages", type: :feature do
+  let(:user) { create(:user) }
+
+  before do
+    sign_in(user)
+  end
+
+  context "on 403 error page" do
+    it "allows user to log out" do
+      visit "/403"
+      expect(page).to have_link("Log out")
+
+      click_link "Log out"
+      expect(page).to have_content("Signed out successfully")
+    end
+  end
+
+  context "on 404 error page" do
+    it "allows user to log out" do
+      visit "/404"
+      expect(page).to have_link("Log out")
+
+      click_link "Log out"
+      expect(page).to have_content("Signed out successfully")
+    end
+  end
+
+  context "on 422 error page" do
+    it "allows user to log out" do
+      visit "/422"
+      expect(page).to have_link("Log out")
+
+      click_link "Log out"
+      expect(page).to have_content("Signed out successfully")
+    end
+  end
+
+  context "on 500 error page" do
+    it "allows user to log out" do
+      visit "/500"
+      expect(page).to have_link("Log out")
+
+      click_link "Log out"
+      expect(page).to have_content("Signed out successfully")
+    end
+  end
+end