Merge branch 'main' into 4503-super-admin-create-users

Benjamin-Couey · web-flow · commit 401c41232162 · 2025-04-01T13:27:51.000-07:00
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -831,4 +831,4 @@ DEPENDENCIES
   webmock (~> 3.24)
 
 BUNDLED WITH
-   2.6.5
+   2.6.6
diff --git a/app/views/layouts/_lte_navbar.html.erb b/app/views/layouts/_lte_navbar.html.erb
@@ -50,10 +50,12 @@
         <i class="fa fa-repeat text-aqua"></i><%= "Switch to: #{role.resource&.name || "Super Admin"}" %>
       <% end %>
     <% end %>
-    <% if current_user.has_cached_role?(Role::ORG_ADMIN, current_organization) %>
+   <% if current_user.has_cached_role?(Role::ORG_ADMIN, current_organization) %>
         <div class="dropdown-divider"></div>
-        <%= link_to users_path, class:"dropdown-item" do %>
-          <i class="fas fa-users mr-2"></i> My Co-Workers
+        <% if current_user.has_cached_role?(:partner) %>
+          <%= link_to users_path, class:"dropdown-item" do %>
+            <i class="fas fa-users mr-2"></i> My Co-Workers
+          <% end %>
         <% end %>
         <%= link_to organization_path, class:"dropdown-item" do %>
           <i class="fas fa-sitemap mr-2"></i> My Organization
diff --git a/docs/user_guide/bank/account_management.md b/docs/user_guide/bank/account_management.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Account Management
 
 ## Logging out
diff --git a/docs/user_guide/bank/asking_for_changes.md b/docs/user_guide/bank/asking_for_changes.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Asking for changes
 
 We welcome ideas for how Human Essentials can support your work better.
diff --git a/docs/user_guide/bank/community_donation_sites.md b/docs/user_guide/bank/community_donation_sites.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Donation Sites
 
 Donation Sites are places where people drop off Donations.
diff --git a/docs/user_guide/bank/community_manufacturers.md b/docs/user_guide/bank/community_manufacturers.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Manufacturers
 
 The Manufacturers page under the "Community" section lets you manage your Manufacturers and track donations from them.
diff --git a/docs/user_guide/bank/community_product_drive_participants.md b/docs/user_guide/bank/community_product_drive_participants.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Product Drive Participants
 
 If you conduct Product Drives, the Product Drive Participants list lets you manage the participant's contact information and see their Donation history.
diff --git a/docs/user_guide/bank/community_product_drives.md b/docs/user_guide/bank/community_product_drives.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Product Drives
 Many banks hold seasonal or one-off events where they are seeking Donations.  In Human Essentials, Product Drives help manage those events by providing a way to link specific Donations to the events.
 
diff --git a/docs/user_guide/bank/community_vendors.md b/docs/user_guide/bank/community_vendors.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Vendors
 
 The Vendors list lets you manage Vendor contact information and view your Purchases from each Vendor. To access it, click on "Vendors" under the "Community" section.
diff --git a/docs/user_guide/bank/essentials_dashboard.md b/docs/user_guide/bank/essentials_dashboard.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Your Dashboard
 When you log in, your initial screen will be a dashboard with information that is useful on a daily basis for most banks.
 
diff --git a/docs/user_guide/bank/essentials_distributions.md b/docs/user_guide/bank/essentials_distributions.md
@@ -1,6 +1,3 @@
-
-READY FOR REVIEW
-
 # Distributions
 Distributions are where you record what you allocate to your partner agencies.
 
diff --git a/docs/user_guide/bank/essentials_donations.md b/docs/user_guide/bank/essentials_donations.md
@@ -1,6 +1,3 @@
-
-READY FOR REVIEW
-
 # Donations
 Donations are obviously one of the most important elements of an Essential Bank's operations, being the primary way most banks get the goods to distribute to their partners to help folk.
 
diff --git a/docs/user_guide/bank/essentials_pick_ups.md b/docs/user_guide/bank/essentials_pick_ups.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Pick Ups & Deliveries Calendar
 
 Pick Ups & Deliveries shows scheduled and completed distributions in a calendar format on a monthly basis.
diff --git a/docs/user_guide/bank/essentials_purchases.md b/docs/user_guide/bank/essentials_purchases.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Purchases
 The other major way we add to inventory in human essentials is through Purchases.
 
diff --git a/docs/user_guide/bank/essentials_requests.md b/docs/user_guide/bank/essentials_requests.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Requests
 
 Requests are how you get the information on what items the partners need. (You may think of them as orders.)
diff --git a/docs/user_guide/bank/exports.md b/docs/user_guide/bank/exports.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Exports
 
 There are several exports available to allow you to use the information from the application in other apps.
diff --git a/docs/user_guide/bank/getting_started_access_levels.md b/docs/user_guide/bank/getting_started_access_levels.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Levels of Access
 
 There are 4 different levels of access in the system:
diff --git a/docs/user_guide/bank/getting_started_choices.md b/docs/user_guide/bank/getting_started_choices.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Some Things to Think about before Getting Started
 
 Human Essentials is designed to help you manage your inventory and your relationship with partners, while also providing some information to help with your grant writing.
diff --git a/docs/user_guide/bank/getting_started_customization.md b/docs/user_guide/bank/getting_started_customization.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Organization information and customization
 
 Every Essentials Bank has its own way of doing things.
diff --git a/docs/user_guide/bank/getting_started_donation_sites.md b/docs/user_guide/bank/getting_started_donation_sites.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Donation Sites
 A Donation Site represents a drop-off location for donations.
 The information regarding a Donation Site is mainly for your reference.  There are no automated emails that go to the donation sites' contacts.
diff --git a/docs/user_guide/bank/getting_started_inventory.md b/docs/user_guide/bank/getting_started_inventory.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Getting started -- Inventory
 When we set up your organization, we provide a default set of Items ranging from adult briefs to kids (newborn) 
 to tampons. You can modify this list at any time, through the [Inventory Items](inventory_items.md) feature.  
diff --git a/docs/user_guide/bank/getting_started_partners.md b/docs/user_guide/bank/getting_started_partners.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Getting Started -- Partner Management
 
 ## Things you need to know about Partners before deciding how you are handling them
diff --git a/docs/user_guide/bank/getting_started_storage_locations.md b/docs/user_guide/bank/getting_started_storage_locations.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Getting Started -- Storage Locations
 
 A bank can have multiple storage locations -- these range from warehouses down to space in people's houses.  You need at least one storage location in the system.
diff --git a/docs/user_guide/bank/getting_started_user_management.md b/docs/user_guide/bank/getting_started_user_management.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Essentials Bank User Administration
 
 If you're not the sole worker at your Essentials Bank, you'll likely want other staff to have some access to Human Essentials. 
diff --git a/docs/user_guide/bank/intro_i.md b/docs/user_guide/bank/intro_i.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Is Human Essentials Right for You? (What We Help with and What We Don't)
 ## Human Essentials is a free system for Essentials Banks 
 Human Essentials is for Essentials Banks -- by which we mean organizations that distribute essentials (diapers, period products, etc) to other organizations that work directly with people in need.
diff --git a/docs/user_guide/bank/intro_ii.md b/docs/user_guide/bank/intro_ii.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Support
 
 There are a few ways to get support -- some are better than others.
diff --git a/docs/user_guide/bank/inventory_adjustments.md b/docs/user_guide/bank/inventory_adjustments.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Inventory Adjustments
 
 Inventory adjustments are an alternative way to record known differences in the inventory without going through the Audit process.  
diff --git a/docs/user_guide/bank/inventory_audits.md b/docs/user_guide/bank/inventory_audits.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Audits
 
 When you do an inventory count,  you'll want to set the inventory in each Storage Location to the physical count.  That's what the Audits function is for.
diff --git a/docs/user_guide/bank/inventory_barcodes.md b/docs/user_guide/bank/inventory_barcodes.md
@@ -1,4 +1,3 @@
-DRAFT USER GUIDE
 # Barcodes
 
 ## Introduction to Barcodes
diff --git a/docs/user_guide/bank/inventory_items.md b/docs/user_guide/bank/inventory_items.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Items
 ## Introduction
 Your bank is initialized with  a basic set of Items that contains many common product types that essentials banks distribute.   These Items represent the stock you have for distribution.  Here is the current default list:  
diff --git a/docs/user_guide/bank/inventory_kits.md b/docs/user_guide/bank/inventory_kits.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Kits
 
 Many banks distribute Kits -- the classic example is a package that contains different types of menstrual supplies (e.g. pads, tampons, wipes).
diff --git a/docs/user_guide/bank/inventory_storage_locations.md b/docs/user_guide/bank/inventory_storage_locations.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Storage Locations
 
 You need at least one Storage Location.   Each Donation and Purchase increases the inventory in a Storage Location,  and each distribution is made from the inventory in a Storage Location.  
diff --git a/docs/user_guide/bank/inventory_transfers.md b/docs/user_guide/bank/inventory_transfers.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Transfers
 If you have multiple Storage Locations, sometimes you have to move inventory between them.  
 ## Working with Transfers
diff --git a/docs/user_guide/bank/pm_adding_a_partner.md b/docs/user_guide/bank/pm_adding_a_partner.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Adding a single Partner
 To add a single Partner,  you can either Click on the "Add a Partner" button in the "Getting Started" section of your dashboard (if you are, indeed, just getting started), or click "Partner Agencies" in the left-hand menu, then "All Partners", then "New Partner Agency".  Then, fill in the following information, and click "Add Partner Agency".  
 ![Navigation to add a Partner](images/partners/partners_add_navigation.png)
diff --git a/docs/user_guide/bank/pm_announcements.md b/docs/user_guide/bank/pm_announcements.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Partner Announcements
 
 Partner Announcements are a great way to let your partners know about temporary situations -- like when you need to put some limits on what you can give out of a particular size.  Some banks also use them to point to other resources.
diff --git a/docs/user_guide/bank/pm_approving_a_partner.md b/docs/user_guide/bank/pm_approving_a_partner.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Approving Partners
 
 There are three paths in to reviewing a Partner's information before approving them to make Requests: 
diff --git a/docs/user_guide/bank/pm_editing_a_partner.md b/docs/user_guide/bank/pm_editing_a_partner.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Editing a Partner
 
 Note - this is editing a Partner's basic information,  not their [Partner Profile](pm_partner_profiles.md).  What's the difference?  The basic Partner information is what you enter when you are initially creating the Partner, whereas the Partner Profile contains a high level of detail that can be entered by the Partners themselves.
diff --git a/docs/user_guide/bank/pm_importing_partners.md b/docs/user_guide/bank/pm_importing_partners.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Importing partners
 
 **N.B.** We've set up importing partners as a process you only run once to prevent accidental imports and writing over existing partners.
diff --git a/docs/user_guide/bank/pm_inviting_a_partner.md b/docs/user_guide/bank/pm_inviting_a_partner.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Inviting a Partner
 
 Before a Partner can make Requests,  they have to be invited and approved.
diff --git a/docs/user_guide/bank/pm_making_a_partner_inactive.md b/docs/user_guide/bank/pm_making_a_partner_inactive.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Making a Partner inactive
 
 Unfortunately, sometimes a Partner will cease operations.  Should that occur, you can make them inactive.   This does not remove their historical information,  but they won't appear in your selections, or in the all partners list (unless you specifically choose "Deactivated")
diff --git a/docs/user_guide/bank/pm_other_information.md b/docs/user_guide/bank/pm_other_information.md
@@ -1,5 +1,4 @@
-READY FOR REVIEW
-
+# Other Partner Information
 There are a few other things with Partners that didn't fit into any of the sections above:
 
 1/  You can see the Families served, Children served and zipcodes served, when you view a partner
diff --git a/docs/user_guide/bank/pm_partner_groups.md b/docs/user_guide/bank/pm_partner_groups.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Partner Groups
 
 You may have reasons that some partners are treated differently than others.  Reasons we've seen for this include:
diff --git a/docs/user_guide/bank/pm_partner_profiles.md b/docs/user_guide/bank/pm_partner_profiles.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Partner Profiles
 Partner Profiles allow you to gather and hold a lot of information about your Partners that may be useful for meeting your regulatory requirements, managing their experience, and for grant-writing.  
 
diff --git a/docs/user_guide/bank/pm_partner_reactivation.md b/docs/user_guide/bank/pm_partner_reactivation.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Partner reactivation
 
 To reactivate a partner: 
diff --git a/docs/user_guide/bank/pm_partner_statuses.md b/docs/user_guide/bank/pm_partner_statuses.md
@@ -1,5 +1,3 @@
-
-READY FOR REVIEW
 # Partner statuses (what can Partners do when)
 
 As an Essentials Bank, you distribute materials (diapers, period products, etc.) to your Partners who interface with the people in need of the items.
diff --git a/docs/user_guide/bank/pm_partner_user_admin.md b/docs/user_guide/bank/pm_partner_user_admin.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Administering Partner Users
 
 Partners can add Users themselves,  but occasionally a bank may need to step in and administer Partner Users (for instance, if the only person who uses the system leaves the Partner.)
diff --git a/docs/user_guide/bank/pm_request_distribution_cycle.md b/docs/user_guide/bank/pm_request_distribution_cycle.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # The Request/Distribution Cycle
 
 You can distribute materials to your Partners as soon as you have them entered into the system.  However, many banks find it useful to allow their Partners to request products through the system. 
diff --git a/docs/user_guide/bank/pm_requesting_recertification.md b/docs/user_guide/bank/pm_requesting_recertification.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Requesting Recertification
 
 From time to time, perhaps annually, you may want to confirm that the information your Partner has provided is still correct.   That is what "request recertification" is for.
diff --git a/docs/user_guide/bank/readme.md b/docs/user_guide/bank/readme.md
@@ -1,5 +1,4 @@
-READY FOR REVIEW
-
+# Human Essentials User Guide
 This user guide is meant for users of Human Essentials at essentials banks.  As of November 2, 2024, it is a work in progress.  If you are interested in helping out, please reach out to @cielf.
 
 1. Introduction
diff --git a/docs/user_guide/bank/reports_activity_graph.md b/docs/user_guide/bank/reports_activity_graph.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Activity Graph Report
 This report is merely a visual representation of the number of Items processed over a time period.
 
diff --git a/docs/user_guide/bank/reports_annual_survey.md b/docs/user_guide/bank/reports_annual_survey.md
@@ -1,5 +1,4 @@
-READY FOR REVIEW
-## Annual Survey
+# Annual Survey
 The annual survey contains information useful for completing the NDBN or Alliance for Period Supplies annual survey, but also for grant writing.
 Each year's annual survey becomes available January 1 of the following year.
 
diff --git a/docs/user_guide/bank/reports_distributions_by_county.md b/docs/user_guide/bank/reports_distributions_by_county.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Distributions by County Report
 
 
diff --git a/docs/user_guide/bank/reports_history.md b/docs/user_guide/bank/reports_history.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # History Report
 This is mainly used for troubleshooting by the Human Essentials team.  You are unlikely to need it in your day-to-day work.  
 
diff --git a/docs/user_guide/bank/reports_itemized_reports.md b/docs/user_guide/bank/reports_itemized_reports.md
@@ -1,5 +1,3 @@
-READY FOR REVIEW
-
 # Itemized Reports
 
 The itemized reports break down the inventory by Item over a given time period.   There are itemized reports for Donations and for Distributions.  
diff --git a/docs/user_guide/bank/reports_manufacturers_donations.md b/docs/user_guide/bank/reports_manufacturers_donations.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Manufacturers Donations Report
 
 To access this report,  click 'Reports", then "Donations - Manufacturers"
diff --git a/docs/user_guide/bank/reports_summary_reports.md b/docs/user_guide/bank/reports_summary_reports.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Summary Reports
 
 There are 3 Summary reports - one each for Distributions, Donations, and Purchases
diff --git a/docs/user_guide/bank/reports_trends.md b/docs/user_guide/bank/reports_trends.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # Trends Reports
 The trends reports (one each for Distributions, Donations, and Purchases) give you a picture of the activity on any Item over the last 12 months. 
 
diff --git a/docs/user_guide/bank/user_management.md b/docs/user_guide/bank/user_management.md
@@ -1,4 +1,3 @@
-READY FOR REVIEW
 # User Management
 
 The bank organization admin Users can manage both the staff who have access to humanessentials.app at the bank, and at each of the bank's Partners.
diff --git a/spec/requests/user_dropdown_requests_spec.rb b/spec/requests/user_dropdown_requests_spec.rb
@@ -0,0 +1,19 @@
+RSpec.describe "UsernameDropdown", type: :request do
+  let(:organization) { create(:organization) }
+
+  describe "My Co-Workers link visibility" do
+    context "when user does not have partner role" do
+      let(:user) { create(:user, organization: organization) }
+
+      before do
+        user.add_role(Role::ORG_ADMIN, organization)
+        sign_in(user)
+      end
+
+      it "does not show the My Co-Workers link" do
+        get dashboard_path
+        expect(response.body).not_to include("My Co-Workers")
+      end
+    end
+  end
+end
