cleanup CI test failure investigation code

Author: danielabar

.github/workflows/rspec-system.yml

@@ -80,8 +80,6 @@ jobs:
           KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES: true
           KNAPSACK_PRO_LOG_LEVEL: info
           KNAPSACK_PRO_TEST_FILE_PATTERN: "{spec/system/**{,/*/**}/*_spec.rb,spec/requests/**{,/*/**}/*_spec.rb}"
-          # KNAPSACK_PRO_TEST_FILE_PATTERN: "spec/system/distribution_system_spec.rb"
-          # KNAPSACK_PRO_TEST_FILE_PATTERN: "spec/system/investigation_system_spec.rb"
 
         run: |
           RUBYOPT='-W:no-deprecated -W:no-experimental' bin/knapsack_pro_rspec

app/javascript/controllers/date_range_controller.js

@@ -19,7 +19,6 @@ export default class extends Controller {
   validate(event) {
     event.preventDefault();
 
-    // experiment
     if (this.inputTarget.dataset.skipValidation === "true") {
       return;
     }

spec/support/date_range_picker_shared_example.rb

@@ -112,42 +112,19 @@ def date_range_picker_select_range(range_name)
     it "shows a flash notice and filters results as default" do
       visit subject
 
-      # experiment
-      page.execute_script("document.getElementById('filters_date_range').dataset.skipValidation = 'true';")
-
       date_range = "nov 08 - feb 08"
+      page.execute_script("document.getElementById('filters_date_range').dataset.skipValidation = 'true';")
       page.execute_script("document.getElementById('filters_date_range').focus();")
-      puts "🔍 AFTER FOCUS - URL: #{page.current_url}"
       page.execute_script("document.getElementById('filters_date_range').value = '#{date_range}';")
-      puts "🔍 AFTER POPULATE DATE RANGE - URL: #{page.current_url}"
-      # What we really want here is to simulate user hitting Enter to submit the form but only this click worked
-      # But on CI, this ends up triggering a JS alert instead of submitting the form
-      # FIXME: Can we use something like requestSubmit() to submit the form?
-      # https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit
-      # page.execute_script("document.querySelector('[data-test-id=\"filter-button\"]').click();")
-      # === ON CI: JS ALERT SHOWS UP HERE? ===
       page.execute_script(<<~JS)
         var form = document.getElementById('filters_date_range').closest('form');
         form.requestSubmit();
       JS
 
-      # Temp: investigating timing failure on CI and URL has not transitioned yet, it remains on:
-      # URL: http://127.0.0.1:35713/distributions
-      # Whereas locally it's transitioned to reflect the filters:
-      # http://127.0.0.1:53534/distributions?filters%5Bby_item_id%5D=&filters%5Bby_partner%5D=&filters%5Bby_location%5D=&filters%5Bby_state%5D=&filters%5Bdate_range%5D=nov+08+-+feb+08&filters%5Bdate_range_label%5D=during+the+period+31+May+to+31+Aug&button=
-      # So on CI, clicking the filter button after "tabbing" into the date range field does not submit the form, or not yet, and JS alert is running first
-      puts "🔍 AFTER SUBMIT FORM - URL: #{page.current_url}"
-
-      # === ON CI: JS ALERT SHOWS UP HERE OR EVEN EARLIER ===
-
-      puts "📄 Page text: #{page.text}"
       expect(page).to have_css(".alert.notice", text: "Invalid Date range provided. Reset to default date range")
       expect(page).to have_css("table tbody tr", count: 4)
-      # expect(page).to have_selector(".alert.notice", text: "Invalid Date range provided. Reset to default date range", wait: 30)
-      # expect(page).to have_css("table tbody tr", count: 4, wait: 10)
     end
 
-    # Temp remove while investigating CI failure on server-side validation test above
     # This test is similar to the above but simulates user clicking away from the date range field
     # after having tabbed into it to type something invalid. In this case client side validation
     # via a JavaScript alert should be triggered.
@@ -156,9 +133,7 @@ def date_range_picker_select_range(range_name)
 
       date_range = "nov 08 - feb 08"
       page.execute_script("document.getElementById('filters_date_range').focus();")
-      puts "🔍 JS BLUR TEST - AFTER FOCUS - URL: #{page.current_url}"
       page.execute_script("document.getElementById('filters_date_range').value = '#{date_range}';")
-      puts "🔍 JS BLUR TEST - AFTER ENTER VALUE - URL: #{page.current_url}"
 
       accept_alert("Please enter a valid date range (e.g., January 1, 2024 - March 15, 2024).") do
         find('body').click