Move more system tests to request specs

System tests are costly to maintain. Leaving just
the tests that make more sense to be tested
in the browser.

Author: stefannibrasil

spec/requests/requests_requests_spec.rb

@@ -11,10 +11,6 @@
         response
       end
 
-      before do
-        create(:request)
-      end
-
       context "html" do
         let(:response_format) { 'html' }
 
@@ -25,12 +21,37 @@
         let(:response_format) { 'csv' }
 
         it { is_expected.to be_successful }
+
+        context 'when exporting as CSV' do
+          it "exports only the cancelled requests CSV when 'Include Cancelled' is checked and 'Filter by Status' is 'Cancelled'" do
+            create(:request, :started)
+            create(:request, :cancelled)
+
+            get requests_path(format: :csv, params: {include_cancelled: "1", filters: { by_status: :cancelled}})
+
+            csv = CSV.parse(response.body, headers: true)
+
+            expect(csv.count).to eq(1)
+            expect(csv.first["Status"]).to eq("Cancelled")
+          end
+
+          it "exports the requests CSV including cancelled requests when 'Include Cancelled' is checked" do
+            create(:request, :started)
+            create(:request, :cancelled)
+
+            get requests_path(format: :csv, params: {include_cancelled: "1"})
+
+            csv = CSV.parse(response.body, headers: true)
+
+            expect(csv.count).to eq(2)
+            expect(csv[0]["Status"]).to eq("Started")
+            expect(csv[1]["Status"]).to eq("Cancelled")
+          end
+        end
       end
 
       context "when there are pending or started requests" do
-        it "shows print unfulfilled picklists button with correct quantity" do
-          Request.delete_all
-
+        it "shows print unfulfilled picklists button with correct quantity, excluding cancelled requests by default" do
           create(:request, :pending)
           create(:request, :started)
           create(:request, :fulfilled)
@@ -44,9 +65,22 @@
       end
 
       context "when 'include_cancelled' param is present" do
-        it "shows print unfulfilled picklists button with correct quantity including cancelled requests" do
-          Request.delete_all
+        it 'does not display the Cancel button for cancelled requests' do
+          pending_request = create(:request, :pending)
+          cancelled_request = create(:request, :cancelled)
+
+          get requests_path, params: {include_cancelled: "1"}
 
+          page = Nokogiri::HTML(response.body)
+
+          cancelled_request_cancel_button = page.at_css("form[action='/requests/#{cancelled_request.id}/cancelation/new']")
+          expect(cancelled_request_cancel_button).to be_nil
+
+          pending_request_cancel_button = page.at_css("a[href='/requests/#{pending_request.id}/cancelation/new']")
+          expect(pending_request_cancel_button).to be_present
+        end
+
+        it "shows print unfulfilled picklists button with correct quantity including cancelled requests" do
           create(:request, :pending)
           create(:request, :started)
           create(:request, :cancelled)
@@ -60,8 +94,6 @@
 
       context "when 'Include Cancelled?' is checked and filter by Cancelled" do
         it "constrains the list for cancelled requests only" do
-          Request.delete_all
-
           create(:request, :started, comments: "Need more supplies")
           create(:request, :pending, comments: "Awaiting for confirmation")
           create(:request, :cancelled, comments: 'Not necessary anymore')
@@ -76,8 +108,6 @@
 
       context "when there is a filter applied" do
         it "shows only filtered requests, print unfulfilled picklists button with correct quantity" do
-          Request.delete_all
-
           create(:request, :started, comments: "Started request - should appear")
           create(:request, :pending, comments: "Pending request - should not appear")
           create(:request, :cancelled, comments: 'Cancelled request - a comment')
@@ -190,6 +220,24 @@
           expect(response.body).not_to include('Units (if applicable)')
         end
       end
+
+      context 'when the request has a cancelled status' do
+        it 'does not display the Cancel and Fulfill request buttons' do
+          cancelled_request = create(:request, :cancelled, organization:)
+
+          get request_path(cancelled_request)
+
+          page = Nokogiri::HTML(response.body)
+
+          cancel_button = page.at_css("form[action='/requests/#{cancelled_request.id}/cancelation/new']")
+          fulfill_button = page.at_css("form[action='/requests/#{cancelled_request.id}/start']")
+          expect(cancel_button).to be_nil
+          expect(fulfill_button).to be_nil
+
+          print_link = page.at_css("a[href='/requests/#{cancelled_request.id}/print_picklist']")
+          expect(print_link).to be_present
+        end
+      end
     end
 
     describe 'POST #start' do

spec/system/request_system_spec.rb

@@ -30,72 +30,24 @@
       create(:request, :with_item_requests, :pending, partner: partner1, request_items: [{ "item_id": item1.id, "quantity": '16' }])
     end
 
-    it "excludes cancelled requests by default" do
+    it "lists requests" do
       visit subject
-
-      expect(find_field("include_cancelled")).not_to be_checked
-
       expect(page).to have_xpath("//h1", text: "Requests")
-      expect(page.find("table")).to have_content('Started', count: 3)
-      expect(page.find("table")).to have_content('Fulfilled', count: 1)
-      expect(page.find("table")).to have_content('Pending', count: 1)
     end
 
-    context "when 'Include Cancelled?' is checked" do
-      it 'does not display the Cancel button for cancelled requests' do
-        _cancelled_request = create(:request, :with_item_requests, :cancelled, partner: partner1, request_items: [{ "item_id": item1.id, "quantity": '6' }])
+    it "can be exported in CSV" do
+      visit subject
+      click_on "Export Requests"
 
-        visit subject
+      wait_for_download
+      expect(downloads.length).to eq(1)
+      expect(download).to match(/.*\.csv/)
 
-        check "Include Cancelled?"
-        click_on 'Filter'
+      headers, *rows = download_content.split("\n")
 
-        within "table tbody" do
-          expect(page).to have_content("Cancelled", count: 1)
-          expect(page).to have_link("Cancel", count: 5) # 5 requests created in the before block
-        end
-      end
-    end
-
-    context "exporting requests" do
-      it "exports the requests CSV excluding cancelled requests by default" do
-        _cancelled_request = create(:request, :with_item_requests, :cancelled, partner: partner1, request_items: [{ "item_id": item1.id, "quantity": '6' }])
-
-        visit subject
-        click_on "Export Requests"
-
-        wait_for_download
-        expect(downloads.length).to eq(1)
-        expect(download).to match(/.*\.csv/)
-
-        headers, *rows = download_content.split("\n")
-
-        expect(rows.size).to eq(5)
-        expect(rows.join).to have_text(partner1.name, count: 4)
-        expect(rows.join).not_to have_text('Cancelled')
-        expect(headers).to have_text(item2.name, count: 1)
-      end
-
-      it "exports the requests CSV including cancelled requests when 'Include Cancelled' is checked" do
-        _cancelled_request = create(:request, :with_item_requests, :cancelled, partner: partner1, request_items: [{ "item_id": item1.id, "quantity": '6' }])
-
-        visit subject
-        check "Include Cancelled?"
-        click_on 'Filter'
-
-        click_on "Export Requests"
-
-        wait_for_download
-        expect(downloads.length).to eq(1)
-        expect(download).to match(/.*\.csv/)
-
-        headers, *rows = download_content.split("\n")
-
-        expect(rows.size).to eq(6)
-        expect(rows.join).to have_text(partner1.name, count: 5)
-        expect(rows.join).to have_text('Cancelled')
-        expect(headers).to have_text(item2.name, count: 1)
-      end
+      expect(rows.size).to eq(5)
+      expect(rows.join).to have_text(partner1.name, count: 4)
+      expect(headers).to have_text(item2.name, count: 1)
     end
 
     context "when filtering on the index page" do
@@ -160,28 +112,6 @@
           expect(rows.join).to have_text('13', count: 1)
           expect(rows.join).to have_text(partner1.name, count: 1)
         end
-
-        it "exports only the cancelled requests CSV when 'Include Cancelled' is checked and 'Filter by Status' is 'Cancelled'" do
-          _cancelled_request = create(:request, :with_item_requests, :cancelled, partner: partner1, request_items: [{ "item_id": item1.id, "quantity": '6' }])
-
-          visit subject
-          check "Include Cancelled?"
-          select "Cancelled", from: "Filter by status"
-          click_on 'Filter'
-
-          click_on "Export Requests"
-
-          wait_for_download
-          expect(downloads.length).to eq(1)
-          expect(download).to match(/.*\.csv/)
-
-          headers, *rows = download_content.split("\n")
-
-          expect(rows.size).to eq(1)
-          expect(rows.join).to have_text(partner1.name, count: 1)
-          expect(rows.join).to have_text('Cancelled')
-          expect(headers).to have_text(item1.name, count: 1)
-        end
       end
     end
 
@@ -278,19 +208,6 @@
       expect(page).to have_content("334")
     end
 
-    context 'when the request has a cancelled status' do
-      it 'does not display the Cancel and Fulfill request buttons' do
-        cancelled_request = create(:request, :with_item_requests, :cancelled, organization: organization)
-
-        visit request_path(cancelled_request.id)
-
-        expect(page).to have_content('Cancelled')
-        expect(page).not_to have_button('Cancel')
-        expect(page).not_to have_button('Fulfill request')
-        expect(page).to have_content('Print')
-      end
-    end
-
     context "change status request" do
       before do
         visit subject