Merge pull request #5433 from rubyforgood/5432_skip_existing_user_email_validation_for_rejected_and_admin_closed_account_requests

[5432] Skip existing user email validation for account requests that are rejected or closed by admin

Author: awwaiid

app/models/account_request.rb

@@ -94,6 +94,7 @@ def email_not_already_used_by_organization
   end
 
   def email_not_already_used_by_user
+    return if rejected? || admin_closed?
     user = User.find_by(email: email)
     if user && (!organization || user.organization_id != organization.id)
       errors.add(:email, 'already used by an existing User')

spec/models/account_request_spec.rb

@@ -61,6 +61,16 @@
         expect(subject.valid?).to eq(false)
         expect(subject.errors.messages[:email]).to match_array(["already used by an existing User"])
       end
+
+      [:rejected, :admin_closed].each do |status|
+        context "when the status is #{status}" do
+          before { subject.status = status }
+
+          it 'allows the email' do
+            expect(subject).to be_valid
+          end
+        end
+      end
     end
   end