Skip to content

Commit a1efa7d

Browse files
committed
Update total_people_served_with_loose_supplies_per_month to exclude kits
1 parent d006e3e commit a1efa7d

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

app/services/reports/adult_incontinence_report_service.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def total_people_served_with_loose_supplies_per_month
129129
.distributions
130130
.for_year(year)
131131
.joins(line_items: :item)
132-
.merge(Item.adult_incontinence)
132+
.merge(Item.adult_incontinence.where(kit_id: nil)) # exclude kits
133133
.sum('line_items.quantity / COALESCE(items.distribution_quantity, 50.0)')
134134
total_quantity.to_f / 12.0
135135
end

spec/services/reports/adult_incontinence_report_service_spec.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
end
135135

136136
it "returns an accurate number of adult served per month" do
137-
expect(report.adults_served_per_month.round).to eq(109)
137+
expect(report.adults_served_per_month.round).to eq(108)
138138
end
139139

140140
it "should return the number of loose adult incontinence supplies distributed" do
@@ -159,9 +159,9 @@
159159
expect(report.report[:entries]).to match(hash_including({
160160
"% adult incontinence bought" => "60%",
161161
"% adult incontinence supplies donated" => "40%",
162-
"Adults Assisted Per Month" => 233.83,
162+
"Adults Assisted Per Month" => 233.33,
163163
"Adult incontinence supplies distributed" => "51,800",
164-
"Adult incontinence supplies per adult per month" => 18.46,
164+
"Adult incontinence supplies per adult per month" => 18.5,
165165
"Money spent purchasing adult incontinence supplies" => "$30.00"
166166
}))
167167
expect(report.report[:entries]['Adult incontinence supplies'].split(', '))
@@ -188,8 +188,8 @@
188188
"% adult incontinence bought" => "60%",
189189
"% adult incontinence supplies donated" => "40%",
190190
"Adult incontinence supplies distributed" => "51,800",
191-
"Adults Assisted Per Month" => 108.83,
192-
"Adult incontinence supplies per adult per month" => 39.66,
191+
"Adults Assisted Per Month" => 108.33,
192+
"Adult incontinence supplies per adult per month" => 39.85,
193193
"Money spent purchasing adult incontinence supplies" => "$30.00"
194194
}))
195195
expect(report.report[:entries]['Adult incontinence supplies'].split(', '))

0 commit comments

Comments
 (0)