fix(kit_creation): calculate total value in cents for kits and update UI accordingly

Author: Olexii Kasianenko

app/services/kit_create_service.rb

@@ -44,9 +44,10 @@ def call
         raise item_creation_result.error
       end
       kit.items.update_all(visible_to_partners: kit.visible_to_partners)
-      kit.items.each do |item|
-        item.update!(value_in_dollars: kit.value_in_dollars)
+      kit_value_in_cents = kit.items.reduce(0) do |sum, i|
+        sum + i.value_in_cents.to_i * kit.line_items.find_by(item_id: i.id).quantity.to_i
       end
+      kit.update!(value_in_cents: kit_value_in_cents)
     rescue StandardError => e
       errors.add(:base, e.message)
       raise ActiveRecord::Rollback

app/views/kits/_form.html.erb

@@ -14,11 +14,6 @@
                 <%= f.check_box :visible_to_partners, {class: "input-group-text", id: "visible_to_partners"}, "true", "false" %>
               <% end %>
 
-              <%= f.input :value_in_cents, label: "Value for kit", wrapper: :input_group do %>
-                <span class="input-group-text"><i class="fa fa-dollar"></i></span>
-                <%= f.input_field :value_in_dollars, class: "form-control", min: 0 %>
-              <% end %>
-
               <fieldset style="margin-bottom: 2rem;" class='w-70'>
                 <legend>Items in this Kit</legend>
                 <div id="kit_line_items" class="line-item-fields" data-capture-barcode="true">
@@ -38,5 +33,6 @@
           </div>
         </div>
       </div>
+    </div>
   </section>
 <% end %>

app/views/kits/_table.html.erb

@@ -3,6 +3,7 @@
 <tr>
   <th>Name</th>
   <th>Items</th>
+  <th>Value for kit</th>
   <th>Allocations</th>
   <th class="text-right">Actions</th>
 </tr>
@@ -18,6 +19,12 @@
           <% end %>
         </ul>
       </td>
+      <td>
+        <span class="tooltip-target" data-toggle="tooltip" data-placement="top" title="Total value of all items in this kit based on current inventory item values">
+          <%= number_to_currency(kit.value_in_dollars) %>
+          <i class="fa fa-info-circle"></i>
+        </span>
+      </td>
       <td class='d-flex flex-column'>
         <table>
           <thead>

app/views/line_items/_line_item_fields.html.erb

@@ -16,7 +16,6 @@
             <%= field.input :item_id,
                             disabled: requested.present?,
                             collection: @item_labels_with_quantities || @items, prompt: "Choose an item",
-                            include_blank: "",
                             label: false,
                             input_html: { class: "my-0 line_item_name", "data-controller": "select2" } %>
             <% if requested.present? %>

spec/services/kit_create_service_spec.rb

@@ -24,22 +24,25 @@
         }
       end
     end
+    let(:kit_value_in_cents) do
+      line_items_attr.sum do |li|
+        item = Item.find(li[:item_id])
+        item.value_in_cents.to_i * li[:quantity].to_i
+      end
+    end
 
     it 'should return an the instance' do
       expect(subject).to be_a_kind_of(described_class)
     end
 
     context 'when the parameters are valid' do
       it 'should create a new Kit' do
-        expect { subject }.to change { Kit.all.count }.by(1)
+        expect { subject }.to change { Kit.count }.by(1)
+        expect(Kit.last.value_in_cents).to eq(kit_value_in_cents)
       end
 
       it 'should create a new Item' do
-        expect { subject }.to change { Item.all.count }.by(1)
-      end
-
-      it 'should create the new Item associated with the Kit' do
-        expect { subject }.to change { Kit.all.count }.by(1)
+        expect { subject }.to change { Item.count }.by(1)
       end
 
       context 'but an unexpected error gets raised' do
@@ -92,6 +95,14 @@
         end
       end
 
+      context 'line_items_attributes is empty' do
+        let(:line_items_attr) { [] }
+
+        it 'should have an error At least one item is required' do
+          expect(subject.errors.full_messages).to include("At least one item is required")
+        end
+      end
+
       context 'because the kit_params is invalid for kit creation' do
         let(:kit_params) { { organization_id: organization_id } }
         let(:kit_validation_errors) do

spec/system/kit_system_spec.rb

@@ -35,17 +35,21 @@
 
   context "kit creation" do
     let(:kit_traits) { attributes_for(:kit) }
-    let(:item) { Item.last }
-    let(:quantity_per_kit) { 5 }
     let(:value_in_dollars) { 10.10 }
+    let(:value_in_cents) { value_in_dollars * 100 }
+    let!(:items) { create_list(:item, 2, value_in_cents: value_in_cents, organization: organization) }
+    let(:quantity_per_kit) { 5 }
+    let(:kit_value_in_dollars) { (items.count * quantity_per_kit * value_in_dollars).round(2) }
 
     before do
       visit new_kit_path
       fill_in "Name", with: kit_traits[:name]
       find(:css, '#visible_to_partners').set(false)
-      find(:css, '#kit_value_in_dollars').set(value_in_dollars)
-      select item.name, from: "kit_line_items_attributes_0_item_id"
-      find(:css, '#kit_line_items_attributes_0_quantity').set(quantity_per_kit)
+      all(:css, '.line_item_name').first.select(items[0].name)
+      all(:css, '.quantity').first.set(quantity_per_kit)
+      click_link "Add Another Item"
+      all(:css, '.line_item_name').last.select(items[1].name)
+      all(:css, '.quantity').last.set(quantity_per_kit)
     end
 
     subject { click_button "Save" }
@@ -55,14 +59,32 @@
         subject
         expect(page.find(".alert")).to have_content "Kit created successfully"
         expect(page).to have_content(kit_traits[:name])
-        expect(page).to have_content("#{quantity_per_kit} #{item.name}")
+        expect(page).to have_content("#{quantity_per_kit} #{items[0].name}")
+        expect(page).to have_content("#{quantity_per_kit} #{items[1].name}")
         expect(Kit.last.name).to eq(kit_traits[:name])
         expect(Kit.last.visible_to_partners).to eq(false)
-        expect(Kit.last.value_in_dollars).to eq(value_in_dollars)
-        expect(item.reload.visible_to_partners).to eq(false)
-        expect(item.reload.value_in_dollars).to eq(value_in_dollars)
+        expect(Kit.last.value_in_dollars).to eq(kit_value_in_dollars)
+        expect(items[0].reload.visible_to_partners).to eq(false)
+        expect(items[1].reload.visible_to_partners).to eq(false)
+        expect(items[0].reload.value_in_dollars).to eq(value_in_dollars)
+        expect(items[1].reload.value_in_dollars).to eq(value_in_dollars)
       }.to change(Kit, :count).by(1)
     end
+
+    context "items not selected" do
+      before do
+        visit new_kit_path
+        fill_in "Name", with: kit_traits[:name]
+        find(:css, '#visible_to_partners').set(false)
+      end
+
+      it "displays error indicating at least one item is required" do
+        expect {
+          subject
+          expect(page.find(".alert")).to have_content "At least one item is required"
+        }.not_to change(Kit, :count)
+      end
+    end
   end
 
   it "can add items correctly" do
@@ -225,8 +247,6 @@
       visit new_kit_path
       kit_traits = attributes_for(:kit)
 
-      find(:css, '#kit_value_in_dollars').set('10.10')
-
       item = Item.last
       quantity_per_kit = 5
       select item.name, from: "kit_line_items_attributes_0_item_id"