Skip to content

Commit ab38c56

Browse files
committed
Make minor changes to ensure floats and integers are being returned as expected
1 parent 51d0254 commit ab38c56

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

app/services/reports/adult_incontinence_report_service.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ def report
1515
@report ||= { name: 'Adult Incontinence',
1616
entries: {
1717
'Adult incontinence supplies distributed' => number_with_delimiter(total_supplies_distributed),
18-
'Adults Assisted Per Month' => adults_served_per_month.round,
19-
'Adult incontinence supplies per adult per month' => supplies_per_adult_per_month.round,
18+
'Adults Assisted Per Month' => adults_served_per_month.round(2),
19+
'Adult incontinence supplies per adult per month' => supplies_per_adult_per_month.round(2),
2020
'Adult incontinence supplies' => types_of_supplies,
2121
'% adult incontinence supplies donated' => "#{percent_donated.round}%",
2222
'% adult incontinence bought' => "#{percent_bought.round}%",
@@ -36,7 +36,7 @@ def distributed_loose_supplies
3636

3737
# @return [Integer]
3838
def total_supplies_distributed
39-
distributed_loose_supplies + distributed_adult_incontinence_items_from_kits
39+
(distributed_loose_supplies + distributed_adult_incontinence_items_from_kits).to_i
4040
end
4141

4242
def monthly_supplies

spec/services/reports/adult_incontinence_report_service_spec.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
it 'should report zero values' do
1111
expect(report.report[:name]).to eq("Adult Incontinence")
1212
expect(report.report[:entries]).to match(hash_including({
13-
"Adult incontinence supplies distributed" => "0.0",
13+
"Adult incontinence supplies distributed" => "0",
1414
"Adults Assisted Per Month" => 0,
1515
"% adult incontinence bought" => "0%",
1616
"% adult incontinence supplies donated" => "0%",
@@ -159,9 +159,9 @@
159159
expect(report.report[:entries]).to match(hash_including({
160160
"% adult incontinence bought" => "60%",
161161
"% adult incontinence supplies donated" => "40%",
162-
"Adults Assisted Per Month" => 234,
163-
"Adult incontinence supplies distributed" => "51,800.0",
164-
"Adult incontinence supplies per adult per month" => 18,
162+
"Adults Assisted Per Month" => 233.83,
163+
"Adult incontinence supplies distributed" => "51,800",
164+
"Adult incontinence supplies per adult per month" => 18.46,
165165
"Money spent purchasing adult incontinence supplies" => "$30.00"
166166
}))
167167
expect(report.report[:entries]['Adult incontinence supplies'].split(', '))
@@ -187,9 +187,9 @@
187187
expect(report.report[:entries]).to match(hash_including({
188188
"% adult incontinence bought" => "60%",
189189
"% adult incontinence supplies donated" => "40%",
190-
"Adult incontinence supplies distributed" => "51,800.0",
191-
"Adults Assisted Per Month" => 109,
192-
"Adult incontinence supplies per adult per month" => 40,
190+
"Adult incontinence supplies distributed" => "51,800",
191+
"Adults Assisted Per Month" => 108.83,
192+
"Adult incontinence supplies per adult per month" => 39.66,
193193
"Money spent purchasing adult incontinence supplies" => "$30.00"
194194
}))
195195
expect(report.report[:entries]['Adult incontinence supplies'].split(', '))

0 commit comments

Comments
 (0)