Rename KitItem STI class to Kit

Now that the standalone Kit model is gone and KitItem is the sole "kit"
concept, rename the STI subclass from KitItem to Kit to match the UI label,
the /kits routes, and the kit_item-free domain.

- app/models/kit_item.rb -> app/models/kit.rb (class KitItem -> Kit)
- Organization#kit_items association -> #kits
- Update all class refs, is_a? checks, the create service, events,
  reports, views, seeds, factories and specs
- Migration flips the items.type discriminator 'KitItem' -> 'Kit'
- Drop two workarounds that were only needed while the class was KitItem:
  - EventsHelper#eventable_path: with the class named Kit, polymorphic
    routing resolves kit_path directly, so the event history row links
    the eventable normally again
  - the kit form's `url: kits_path, as: :kit` options: a new Kit now
    infers kits_path and the :kit param key by default

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: dorner

app/controllers/items_controller.rb

@@ -11,7 +11,7 @@ def index
     @items = @items.active unless params[:include_inactive_items]
 
     @item_categories = current_organization.item_categories.includes(:items).order('name ASC')
-    @kits = current_organization.kit_items.includes(line_items: :item)
+    @kits = current_organization.kits.includes(line_items: :item)
     @storages = current_organization.storage_locations.active.order(id: :asc)
 
     @include_inactive_items = params[:include_inactive_items]
@@ -139,7 +139,7 @@ def remove_category
 
   def reporting_category_hint
     item = current_organization.items.find(params[:id])
-    if item.is_a?(KitItem)
+    if item.is_a?(Kit)
       "Kits are reported based on their contents."
     end
   end

app/controllers/kits_controller.rb

@@ -4,7 +4,7 @@ def show
   end
 
   def index
-    @kits = current_organization.kit_items.includes(line_items: :item).class_filter(filter_params)
+    @kits = current_organization.kits.includes(line_items: :item).class_filter(filter_params)
     @inventory = View::Inventory.new(current_organization.id)
     unless params[:include_inactive_items]
       @kits = @kits.active
@@ -15,7 +15,7 @@ def index
   def new
     load_form_collections
 
-    @kit = current_organization.kit_items.new
+    @kit = current_organization.kits.new
     @kit.line_items.build
   end
 
@@ -32,21 +32,21 @@ def create
         .join(", ")
 
       load_form_collections
-      @kit = current_organization.kit_items.new(kit_params)
+      @kit = current_organization.kits.new(kit_params)
       @kit.line_items.build if @kit.line_items.empty?
 
       render :new
     end
   end
 
   def deactivate
-    @kit = current_organization.kit_items.find(params[:id])
+    @kit = current_organization.kits.find(params[:id])
     @kit.deactivate!
     redirect_back_or_to(dashboard_path, notice: "Kit has been deactivated!")
   end
 
   def reactivate
-    @kit = current_organization.kit_items.find(params[:id])
+    @kit = current_organization.kits.find(params[:id])
     if @kit.can_reactivate?
       @kit.reactivate
       redirect_back_or_to(dashboard_path, notice: "Kit has been reactivated!")
@@ -56,15 +56,15 @@ def reactivate
   end
 
   def allocations
-    @kit = current_organization.kit_items.find(params[:id])
+    @kit = current_organization.kits.find(params[:id])
     @storage_locations = current_organization.storage_locations.active
     @inventory = View::Inventory.new(current_organization.id)
 
     load_form_collections
   end
 
   def allocate
-    @kit = current_organization.kit_items.find(params[:id])
+    @kit = current_organization.kits.find(params[:id])
     @storage_location = current_organization.storage_locations.active.find(kit_adjustment_params[:storage_location_id])
     @change_by = kit_adjustment_params[:change_by].to_i
     begin
@@ -87,7 +87,7 @@ def load_form_collections
   end
 
   def kit_params
-    params.require(:kit_item).permit(
+    params.require(:kit).permit(
       :name,
       :visible_to_partners,
       :value_in_dollars,

app/events/kit_allocate_event.rb

@@ -1,6 +1,6 @@
 class KitAllocateEvent < Event
-  def self.event_line_items(kit_item, storage_location, quantity)
-    items = kit_item.line_items.map do |item|
+  def self.event_line_items(kit, storage_location, quantity)
+    items = kit.line_items.map do |item|
       EventTypes::EventLineItem.new(
         quantity: item.quantity * quantity,
         item_id: item.item_id,
@@ -11,22 +11,22 @@ def self.event_line_items(kit_item, storage_location, quantity)
     end
     items.push(EventTypes::EventLineItem.new(
       quantity: quantity,
-      item_id: kit_item.id,
-      item_value_in_cents: kit_item.value_in_cents,
+      item_id: kit.id,
+      item_value_in_cents: kit.value_in_cents,
       to_storage_location: storage_location,
       from_storage_location: nil
     ))
     items
   end
 
-  def self.publish(kit_item, storage_location, quantity)
+  def self.publish(kit, storage_location, quantity)
     create!(
-      eventable: kit_item,
-      group_id: "kit-allocate-#{kit_item.id}-#{SecureRandom.hex}",
-      organization_id: kit_item.organization_id,
+      eventable: kit,
+      group_id: "kit-allocate-#{kit.id}-#{SecureRandom.hex}",
+      organization_id: kit.organization_id,
       event_time: Time.zone.now,
       data: EventTypes::InventoryPayload.new(
-        items: event_line_items(kit_item, storage_location, quantity)
+        items: event_line_items(kit, storage_location, quantity)
       )
     )
   end

app/events/kit_deallocate_event.rb

@@ -1,6 +1,6 @@
 class KitDeallocateEvent < Event
-  def self.event_line_items(kit_item, storage_location, quantity)
-    items = kit_item.line_items.map do |item|
+  def self.event_line_items(kit, storage_location, quantity)
+    items = kit.line_items.map do |item|
       EventTypes::EventLineItem.new(
         quantity: item.quantity * quantity,
         item_id: item.item_id,
@@ -11,22 +11,22 @@ def self.event_line_items(kit_item, storage_location, quantity)
     end
     items.push(EventTypes::EventLineItem.new(
       quantity: quantity,
-      item_id: kit_item.id,
-      item_value_in_cents: kit_item.value_in_cents,
+      item_id: kit.id,
+      item_value_in_cents: kit.value_in_cents,
       from_storage_location: storage_location,
       to_storage_location: nil
     ))
     items
   end
 
-  def self.publish(kit_item, storage_location, quantity)
+  def self.publish(kit, storage_location, quantity)
     create(
-      eventable: kit_item,
-      group_id: "kit-deallocate-#{kit_item.id}-#{SecureRandom.hex}",
-      organization_id: kit_item.organization_id,
+      eventable: kit,
+      group_id: "kit-deallocate-#{kit.id}-#{SecureRandom.hex}",
+      organization_id: kit.organization_id,
       event_time: Time.zone.now,
       data: EventTypes::InventoryPayload.new(
-        items: event_line_items(kit_item, storage_location, quantity)
+        items: event_line_items(kit, storage_location, quantity)
       )
     )
   end

app/helpers/events_helper.rb

@@ -45,7 +45,7 @@ class Event < ApplicationRecord
   def no_intervening_snapshot
     return if is_a?(SnapshotEvent)
     return unless eventable.respond_to?(:organization)
-    return if eventable.is_a?(KitItem)
+    return if eventable.is_a?(Kit)
 
     intervening = SnapshotEvent.intervening(eventable)
     if intervening.present?

app/models/event.rb

@@ -101,7 +101,7 @@ def is_in_kit?(kits = nil)
     if kits
       kits.any? { |k| k.line_items.map(&:item_id).include?(id) }
     else
-      organization.kit_items
+      organization.kits
         .active
         .joins(:line_items)
         .where(line_items: { item_id: id}).any?
@@ -191,7 +191,7 @@ def set_default_distribution_quantity
     self.distribution_quantity ||= default_distribution_quantity
   end
 
-  # Overridden in KitItem (kits default to 1).
+  # Overridden in Kit (kits default to 1).
   def default_distribution_quantity
     50
   end

app/models/item.rb

@@ -22,10 +22,10 @@
 #  kit_id                       :integer
 #  organization_id              :integer
 #
-class KitItem < Item
+class Kit < Item
   scope :by_name, ->(name) { where("name ILIKE ?", "%#{name}%") }
 
-  # Kit items are managed through the kits UI (deactivate/reactivate), not the normal
+  # Kits are managed through the kits UI (deactivate/reactivate), not the normal
   # item-deletion path.
   def can_delete?(inventory = nil, kits = nil)
     false

app/models/kit_item.rb app/models/kit.rbapp/models/kit_item.rb renamed to app/models/kit.rb

@@ -86,7 +86,7 @@ class Organization < ApplicationRecord
       class_name: "Tag", inverse_of: false
     has_many :inventory_items, through: :storage_locations
     has_many :concrete_items
-    has_many :kit_items
+    has_many :kits
     has_many :transfers
     has_many :users, -> { distinct }, through: :roles
     has_many :vendors

app/models/organization.rb

@@ -23,15 +23,15 @@ def call
 
     organization.transaction do
       if kit_params[:line_items_attributes].blank?
-        @kit = build_kit_item
+        @kit = build_kit
         @kit.errors.add(:base, 'At least one item is required')
         raise ActiveRecord::RecordInvalid.new(@kit)
       end
 
-      # A kit is just a KitItem - an Item that contains other items as line items.
+      # A kit is an Item (STI type 'Kit') that contains other items as line items.
       item_creation = ItemCreateService.new(
         organization_id: organization.id,
-        item_params: kit_item_params
+        item_params: kit_attributes
       )
 
       item_creation_result = item_creation.call
@@ -56,16 +56,16 @@ def organization
     @organization ||= Organization.find_by(id: organization_id)
   end
 
-  # All kit items share the same "Kit" base item / partner_key.
-  def kit_item_params
+  # All kits share the same "Kit" base item / partner_key.
+  def kit_attributes
     kit_params.merge(
-      type: 'KitItem',
+      type: 'Kit',
       partner_key: KitCreateService.find_or_create_kit_base_item!.partner_key
     )
   end
 
-  def build_kit_item
-    organization.kit_items.new(kit_params.except(:line_items_attributes))
+  def build_kit
+    organization.kits.new(kit_params.except(:line_items_attributes))
   end
 
   def valid?
@@ -85,9 +85,9 @@ def kit_validation_errors
     return @kit_validation_errors if @kit_validation_errors
 
     # Exclude line_items_attributes; the line item validity is checked when the item is saved.
-    kit_item = build_kit_item
-    kit_item.valid?
+    kit = build_kit
+    kit.valid?
 
-    @kit_validation_errors = kit_item.errors
+    @kit_validation_errors = kit.errors
   end
 end