Working tests

Author: jparcill

app/services/exports/export_distributions_csv_service.rb

@@ -42,7 +42,7 @@ def generate_csv_data
     def generate_csv_stream
       yield CSV.generate_line(base_headers + item_headers)
 
-      distributions.find_each(batch_size: 500) do |distribution|
+      distributions.each do |distribution|
         yield CSV.generate_line(build_row_data(distribution))
       end
     end

spec/services/exports/export_distributions_csv_service_spec.rb

@@ -5,8 +5,14 @@
   let(:include_in_kind_values) { false }
   let(:include_packages) { false }
 
-  describe '#generate_csv' do
-    subject { described_class.new(distributions: distributions, organization: organization, filters: filters).generate_csv }
+  describe '#generate_csv_stream' do
+    subject do
+      rows = ""
+      described_class.new(distributions: distributions, organization: organization, filters: filters).generate_csv_stream do |row|
+        rows << row
+      end
+      rows
+    end
 
     let(:duplicate_item) { create(:item, name: "Dupe Item", value_in_cents: 300, organization: organization, package_size: 2) }
 
@@ -174,7 +180,7 @@
     end
 
     context 'when there are no distributions but the report is requested' do
-      subject { described_class.new(distributions: [], organization: organization, filters: filters).generate_csv }
+      let(:distributions) { [] }
       it 'returns a csv with only headers and no rows' do
         csv = <<~CSV
           Partner,Initial Allocation,Scheduled for,Source Inventory,Total Number of #{item_name},Total Value of #{item_name},Delivery Method,Shipping Cost,Status,Agency Representative,Comments,Reporting Category,Dupe Item