Error message is more inline with expectations

Author: Budmin

app/controllers/partners/family_requests_controller.rb

@@ -29,7 +29,7 @@ def create
       if create_service.errors.none?
         redirect_to partners_request_path(create_service.partner_request), notice: "Requested items successfully!"
       else
-        redirect_to new_partners_family_request_path, error: "Request failed! #{create_service.errors.map { |error| error.message.to_s }}"
+        redirect_to new_partners_family_request_path, error: create_service.errors.map { |error| error.message.to_s }.join(",").to_s
       end
     end
 

app/services/partners/family_request_create_service.rb

@@ -86,16 +86,17 @@ def check_for_item_visibility
         item_errors = invisible_items.map do |item|
           item_name = included_items_by_id[item[:item_id]].name
 
-          child_count = item[:children].length
+          children_names = item[:children].map { |c| "#{c.first_name} #{c.last_name}" }.join(", ")
 
-          "#{item_name} requested for #{child_count} child#{"ren" if child_count > 1} is not currently available for request."
+          "\"#{item_name}\" requested for #{children_names} is not currently available for request."
         end
 
         joined_errors = item_errors.join(", ")
 
         # don't want to show a memflash error
         if joined_errors.length >= Memflash.threshold
-          errors.add(:base, item_errors.first)
+          truncated_errors = joined_errors[0...(Memflash.threshold - 10)]
+          errors.add(:base, "#{truncated_errors}...")
         else
           errors.add(:base, joined_errors)
         end

spec/requests/partners/family_requests_requests_spec.rb

@@ -57,7 +57,8 @@
 
       subject
 
-      expected = "Request failed! [\"#{i.name} requested for 1 child is not currently available for request.\"]"
+      child_with_unavailable_item = children[0]
+      expected = "\"#{i.name}\" requested for #{child_with_unavailable_item.first_name} #{child_with_unavailable_item.last_name} is not currently available for request."
 
       expect(response.request.flash[:error]).to eql expected
     end
@@ -73,7 +74,11 @@
 
       subject
 
-      expected = "Request failed! [\"#{i.name} requested for 2 children is not currently available for request.\"]"
+      children_with_unavailable_item = children[0..1]
+
+      child_formatting = children_with_unavailable_item.map { |c| "#{c.first_name} #{c.last_name}" }.join(", ")
+
+      expected = "\"#{i.name}\" requested for #{child_formatting} is not currently available for request."
 
       expect(response.request.flash[:error]).to eql expected
     end