Change header to comply with existing documentation

Author: cyang-el

app/services/exports/export_adjustments_csv_service.rb

@@ -19,8 +19,8 @@ def generate_csv_data
 
     def headers
       [
-        "Created", "Storage Location",
-        "Comment", "User", "Changes"
+        "Created date", "Storage Area",
+        "Comment", "# of changes"
       ] + item_names
     end
 
@@ -33,7 +33,6 @@ def build_row(adjustment)
         adjustment.created_at.strftime("%F"),
         adjustment.storage_location.name,
         adjustment.comment,
-        adjustment.user&.name || "Unknown",
         adjustment.line_items.count { |item| !item.quantity.eql?(0) }
       ]
 

docs/user_guide/bank/exports.md

@@ -27,9 +27,10 @@ The exports available include (in alphabetical order):
 Click "Inventory", then "Inventory Adjustments" in the left-hand menu.  Then click "Export Adjustments",
 
 ### Contents of adjustment export
-Creation date, Organization, Storage Area, Comment, # of changes.
-
-[! NOTE]  We have improving the adjustments export to include the changes made in each adjustment on our todo list. We'll also remove the organization as redundant information. Please reach out if this is a priority for you.
+- Creation date
+- Storage Area, Comment
+- # of changes
+- the quantity of each of your organization's Items in the adjustments
 
 ## Annual Survey
 ### Navigating to export annual survey

spec/controllers/adjustments_controller_spec.rb

@@ -42,11 +42,10 @@
 
       it "includes appropriate headers for adjustments" do
         get :index, format: :csv
-        expect(response.body).to include("Created")
-        expect(response.body).to include("Storage Location")
+        expect(response.body).to include("Created date")
+        expect(response.body).to include("Storage Area")
         expect(response.body).to include("Comment")
-        expect(response.body).to include("User")
-        expect(response.body).to include("Changes")
+        expect(response.body).to include("# of changes")
         expect(response.body).to include(item1.name)
         expect(response.body).to include(item2.name)
       end
@@ -62,10 +61,10 @@
 
         expect(parsed_csv[0][item1.name]).to eq("10")
         expect(parsed_csv[0][item2.name]).to eq("5")
-        expect(parsed_csv[0]["Changes"]).to eq("2")
+        expect(parsed_csv[0]["# of changes"]).to eq("2")
 
         expect(parsed_csv[1][item1.name]).to eq("-5")
-        expect(parsed_csv[1]["Changes"]).to eq("1")
+        expect(parsed_csv[1]["# of changes"]).to eq("1")
       end
 
       context "when filtering by date" do

spec/services/exports/export_adjustments_csv_service_spec.rb

@@ -1,4 +1,4 @@
-RSpec.describe Exports::ExportAdjustmentsCSVService do
+RSpec.describe Exports::ExportAdjustmentsCSVService, :wip do
   # Create organization after items to ensure proper associations
   let!(:item1) { create(:item, name: 'item1') }
   let!(:item2) { create(:item, name: 'item2') }
@@ -21,8 +21,8 @@
 
   let(:expected_headers) do
     [
-      "Created", "Storage Location",
-      "Comment", "User", "Changes"
+      "Created date", "Storage Area",
+      "Comment", "# of changes"
     ] + sorted_item_names
   end
 
@@ -77,7 +77,6 @@
           adjustments[0].created_at.strftime("%F"),
           storage_location.name,
           "adjustment 1",
-          user.name,
           2  # Number of items changed
         )
 
@@ -86,7 +85,6 @@
           adjustments[1].created_at.strftime("%F"),
           storage_location.name,
           "adjustment 2",
-          user.name,
           1  # Number of items changed
         )
 
@@ -95,7 +93,6 @@
           adjustments[2].created_at.strftime("%F"),
           storage_location.name,
           "adjustment 3",
-          user.name,
           1  # Number of items changed
         )
       end
@@ -131,7 +128,7 @@
       end
 
       it "should correctly sum up the number of changes" do
-        idx = expected_headers.index("Changes")
+        idx = expected_headers.index("# of changes")
         expect(subject[1][idx]).to eq(2)
         expect(subject[2][idx]).to eq(1)
         expect(subject[3][idx]).to eq(1)
@@ -166,16 +163,16 @@
     it "generates valid CSV data" do
       expect(subject).to be_a(String)
       parsed_csv = CSV.parse(subject, headers: true)
-      expect(parsed_csv.headers).to include("Created",
-        "Storage Location",
+      expect(parsed_csv.headers).to include("Created date",
+        "Storage Area",
         "Comment",
-        "Changes",
+        "# of changes",
         item1.name,
         item2.name,
         item3.name,
         item4.name)
 
-      expect(parsed_csv.first["Changes"]).to eq("2")
+      expect(parsed_csv.first["# of changes"]).to eq("2")
       expect(parsed_csv.first[item1.name]).to eq("111")
       expect(parsed_csv.first[item2.name]).to eq("-7")
     end