Reorder and relabel transfer action buttons to Undo (5560)

Author: augustocbx

app/views/transfers/_transfer_row.html.erb

@@ -5,7 +5,7 @@
   <td><%= transfer_row.comment || "none" %></td>
   <td class="numeric"><%= transfer_row.line_items.total %></td>
   <td class="text-right">
-    <%= delete_button_to transfer_path(transfer_row.id), { confirm: "Are you sure you want to permanently remove this transfer?" } %>
     <%= view_button_to transfer_row %>
+    <%= delete_button_to transfer_path(transfer_row.id), { text: "Undo", icon: "undo", confirm: "Are you sure you want to undo this transfer?" } %>
   </td>
 </tr>

spec/requests/transfers_request_spec.rb

@@ -0,0 +1,35 @@
+RSpec.describe "Transfers", type: :request do
+  let(:organization) { create(:organization) }
+  let(:user) { create(:user, organization: organization) }
+
+  before { sign_in(user) }
+
+  describe "GET #index" do
+    let!(:transfer) { create(:transfer, organization: organization) }
+
+    it "renders the View button before the Undo button" do
+      get transfers_path
+
+      view_position = response.body.index("fa-search")
+      undo_position = response.body.index("fa-undo")
+
+      expect(view_position).to be_present
+      expect(undo_position).to be_present
+      expect(view_position).to be < undo_position
+    end
+
+    it "labels the destructive action as Undo with the undo icon" do
+      get transfers_path
+
+      expect(response.body).to include("Undo")
+      expect(response.body).to include("fa-undo")
+      expect(response.body).not_to include("fa-trash")
+    end
+
+    it "asks for confirmation worded as an undo" do
+      get transfers_path
+
+      expect(response.body).to include("Are you sure you want to undo this transfer?")
+    end
+  end
+end

spec/system/transfer_system_spec.rb

@@ -80,7 +80,7 @@ def create_transfer(amount, from_name, to_name, click_save: true, click_confirm:
     expect(inventory.quantity_for(storage_location: to_storage_location.id, item_id: item.id)).to eq(transfer_amount)
 
     accept_confirm do
-      click_button 'Delete'
+      click_button 'Undo'
     end
 
     expect(page).to have_content(/Successfully deleted Transfer/)
@@ -109,7 +109,7 @@ def create_transfer(amount, from_name, to_name, click_save: true, click_confirm:
     allow(TransferDestroyEvent).to receive(:publish).and_raise('OH NOES')
 
     accept_confirm do
-      click_button 'Delete'
+      click_button 'Undo'
     end
 
     expect(page).to have_content(/OH NOES/)