Fix lint errors

dorner · dorner · commit ed143faaacb3 · 2026-05-08T16:04:28.000-04:00
diff --git a/app/controllers/admin/users_controller.rb b/app/controllers/admin/users_controller.rb
@@ -24,7 +24,7 @@ def update
       redirect_to admin_users_path
     else
       flash[:error] = "Something didn't work quite right -- try again?"
-      redirect_back(fallback_location: edit_admin_user_path)
+      redirect_back_or_to(edit_admin_user_path)
     end
   end
 
@@ -81,23 +81,23 @@ def add_role
         resource_type: params[:resource_type],
         resource_id: params[:resource_id])
     rescue => e
-      redirect_back(fallback_location: admin_users_path, alert: e.message)
+      redirect_back_or_to(admin_users_path, alert: e.message)
       return
     end
-    redirect_back(fallback_location: admin_users_path, notice: "Role added!")
+    redirect_back_or_to(admin_users_path, notice: "Role added!")
   end
 
   def resend_invitation
     user = User.find(params[:user_id])
     user.invite!
-    redirect_back(fallback_location: admin_users_path, notice: "#{user.name} reinvited!")
+    redirect_back_or_to(admin_users_path, notice: "#{user.name} reinvited!")
   end
 
   def remove_role
     RemoveRoleService.call(user_id: params[:user_id], role_id: params[:role_id])
-    redirect_back(fallback_location: admin_users_path, notice: "Role removed!")
+    redirect_back_or_to(admin_users_path, notice: "Role removed!")
   rescue => e
-    redirect_back(fallback_location: admin_users_path, alert: e.message)
+    redirect_back_or_to(admin_users_path, alert: e.message)
   end
 
   private
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -19,7 +19,7 @@ class ApplicationController < ActionController::Base
 
   def session_expired
     flash[:error] = "Your session expired. This could be due to leaving a page open for a long time, or having multiple tabs open. Try resubmitting."
-    redirect_back fallback_location: root_path
+    redirect_back_or_to(root_path)
   end
 
   def current_organization
diff --git a/app/controllers/attachments_controller.rb b/app/controllers/attachments_controller.rb
@@ -2,6 +2,6 @@ class AttachmentsController < ApplicationController
   def destroy
     ActiveStorage::Attachment.find(params[:id])&.purge
 
-    redirect_back fallback_location: partners_path
+    redirect_back_or_to(partners_path)
   end
 end
diff --git a/app/controllers/audits_controller.rb b/app/controllers/audits_controller.rb
@@ -32,7 +32,7 @@ def finalize
     @audit.finalized!
     redirect_to audit_path(@audit), notice: "Audit is Finalized."
   rescue => e
-    redirect_back(fallback_location: audits_path, alert: "Could not finalize audit: #{e.message}")
+    redirect_back_or_to(audits_path, alert: "Could not finalize audit: #{e.message}")
   end
 
   def update
diff --git a/app/controllers/concerns/importable.rb b/app/controllers/concerns/importable.rb
@@ -39,7 +39,7 @@ def import_csv
     else
       flash[:error] = "No file was attached!"
     end
-    redirect_back(fallback_location: { action: :index, organization_id: current_organization })
+    redirect_back_or_to({ action: :index, organization_id: current_organization })
   end
 
   private
diff --git a/app/controllers/distributions_controller.rb b/app/controllers/distributions_controller.rb
@@ -272,7 +272,7 @@ def picked_up
       flash[:error] = 'Sorry, we encountered an error when trying to mark this distribution as being completed'
     end
 
-    redirect_back(fallback_location: distribution_path)
+    redirect_back_or_to(distribution_path)
   end
 
   def pickup_day
diff --git a/app/controllers/donation_sites_controller.rb b/app/controllers/donation_sites_controller.rb
@@ -26,7 +26,7 @@ def create
       else
         flash.now[:error] = "Something didn't work quite right -- try again?"
         if request.format.turbo_stream?
-          format.html { render partial: "donation_sites/new_modal", status: :unprocessable_entity }
+          format.html { render partial: "donation_sites/new_modal", status: :unprocessable_content }
         end
 
         format.html do
@@ -69,7 +69,7 @@ def deactivate
       donation_site.deactivate!
     rescue => e
       flash[:error] = e.message
-      redirect_back(fallback_location: donation_sites_path)
+      redirect_back_or_to(donation_sites_path)
       return
     end
 
@@ -83,7 +83,7 @@ def reactivate
       donation_site.reactivate!
     rescue => e
       flash[:error] = e.message
-      redirect_back(fallback_location: donation_sites_path)
+      redirect_back_or_to(donation_sites_path)
       return
     end
 
diff --git a/app/controllers/items_controller.rb b/app/controllers/items_controller.rb
@@ -95,7 +95,7 @@ def deactivate
       item.deactivate!
     rescue => e
       flash[:error] = e.message
-      redirect_back(fallback_location: items_path)
+      redirect_back_or_to(items_path)
       return
     end
 
@@ -108,7 +108,7 @@ def destroy
     item.destroy
     if item.errors.any?
       flash[:error] = item.errors.full_messages.join("\n")
-      redirect_back(fallback_location: items_path)
+      redirect_back_or_to(items_path)
       return
     end
 
diff --git a/app/controllers/kits_controller.rb b/app/controllers/kits_controller.rb
@@ -46,16 +46,16 @@ def create
   def deactivate
     @kit = current_organization.kits.find(params[:id])
     @kit.deactivate
-    redirect_back(fallback_location: dashboard_path, notice: "Kit has been deactivated!")
+    redirect_back_or_to(dashboard_path, notice: "Kit has been deactivated!")
   end
 
   def reactivate
     @kit = current_organization.kits.find(params[:id])
     if @kit.can_reactivate?
       @kit.reactivate
-      redirect_back(fallback_location: dashboard_path, notice: "Kit has been reactivated!")
+      redirect_back_or_to(dashboard_path, notice: "Kit has been reactivated!")
     else
-      redirect_back(fallback_location: dashboard_path, alert: "Cannot reactivate kit - it has inactive items! Please reactivate the items first.")
+      redirect_back_or_to(dashboard_path, alert: "Cannot reactivate kit - it has inactive items! Please reactivate the items first.")
     end
   end
 
diff --git a/app/controllers/organizations_controller.rb b/app/controllers/organizations_controller.rb
@@ -51,7 +51,7 @@ def promote_to_org_admin
         resource_id: current_organization.id)
       redirect_to user_update_redirect_path, notice: "User has been promoted!"
     rescue => e
-      redirect_back(fallback_location: organization_path, alert: e.message)
+      redirect_back_or_to(organization_path, alert: e.message)
     end
   end
 
@@ -64,7 +64,7 @@ def demote_to_user
         resource_id: current_organization.id)
       redirect_to user_update_redirect_path, notice: "User has been demoted!"
     rescue => e
-      redirect_back(fallback_location: organization_path, alert: e.message)
+      redirect_back_or_to(organization_path, alert: e.message)
     end
   end
 
@@ -77,7 +77,7 @@ def remove_user
         resource_id: current_organization.id)
       redirect_to user_update_redirect_path, notice: "User has been removed!"
     rescue => e
-      redirect_back(fallback_location: organization_path, alert: e.message)
+      redirect_back_or_to(organization_path, alert: e.message)
     end
   end
 
diff --git a/app/controllers/partner_users_controller.rb b/app/controllers/partner_users_controller.rb
@@ -17,8 +17,7 @@ def create
       resource: @partner
     )
     if @user.valid?
-      redirect_back(fallback_location: "/",
-        notice: "#{@user.name} has been invited. Invitation email sent to #{@user.email}")
+      redirect_back_or_to("/", notice: "#{@user.name} has been invited. Invitation email sent to #{@user.email}")
     else
       flash.now[:alert] = "Invitation failed. Check the form for errors."
       @users = @partner.users
@@ -33,9 +32,9 @@ def destroy
     user = User.find(params[:id])
 
     if user.remove_role(Role::PARTNER, @partner)
-      redirect_back(fallback_location: "/", notice: "Access to #{@partner.name} has been revoked for #{user.display_name}.")
+      redirect_back_or_to("/", notice: "Access to #{@partner.name} has been revoked for #{user.display_name}.")
     else
-      redirect_back(fallback_location: "/", alert: "Invitation failed. Check the form for errors.")
+      redirect_back_or_to("/", alert: "Invitation failed. Check the form for errors.")
     end
   end
 
@@ -49,17 +48,17 @@ def resend_invitation
     end
 
     if user.errors.none?
-      redirect_back(fallback_location: "/", notice: "Invitation email sent to #{user.email}")
+      redirect_back_or_to("/", notice: "Invitation email sent to #{user.email}")
     else
-      redirect_back(fallback_location: "/", alert: user.errors.full_messages.to_sentence)
+      redirect_back_or_to("/", alert: user.errors.full_messages.to_sentence)
     end
   end
 
   def reset_password
     user = User.find(params[:id])
 
     user.send_reset_password_instructions
-    redirect_back(fallback_location: root_path, notice: "Password e-mail sent!")
+    redirect_back_or_to(root_path, notice: "Password e-mail sent!")
   end
 
   private
diff --git a/app/controllers/partners/authorized_family_members_controller.rb b/app/controllers/partners/authorized_family_members_controller.rb
@@ -38,7 +38,7 @@ def destroy
       @authorized_family_member = current_partner.authorized_family_members.find_by(id: params[:id])
       if @authorized_family_member.present?
         @authorized_family_member.destroy
-        redirect_back fallback_location: partners_families_url, notice: "Authorized family member removed."
+        redirect_back_or_to(partners_families_url, notice: "Authorized family member removed.")
       end
     end
 
diff --git a/app/controllers/storage_locations_controller.rb b/app/controllers/storage_locations_controller.rb
@@ -82,17 +82,17 @@ def show
 
   def import_inventory
     if params[:file].nil?
-      redirect_back(fallback_location: storage_locations_path)
+      redirect_back_or_to(storage_locations_path)
       flash[:error] = "No file was attached!"
     else
       filepath = params[:file].read
       StorageLocation.import_inventory(filepath, current_organization.id, params[:storage_location])
       flash[:notice] = "Inventory imported successfully!"
-      redirect_back(fallback_location: storage_locations_path)
+      redirect_back_or_to(storage_locations_path)
     end
   rescue Errors::InventoryAlreadyHasItems => e
     flash[:error] = e.message
-    redirect_back(fallback_location: storage_locations_path(organization_id: current_organization))
+    redirect_back_or_to(storage_locations_path(organization_id: current_organization))
   end
 
   def update
@@ -111,8 +111,7 @@ def deactivate
     if svc.call
       redirect_to storage_locations_path, notice: "Storage Location deactivated successfully"
     else
-      redirect_back(fallback_location: storage_locations_path,
-        error: "Cannot deactivate storage location containing inventory items with non-zero quantities")
+      redirect_back_or_to(storage_locations_path, error: "Cannot deactivate storage location containing inventory items with non-zero quantities")
     end
   end
 
@@ -121,7 +120,7 @@ def reactivate
     if @storage_location.undiscard!
       redirect_to storage_locations_path, notice: "Storage Location reactivated successfully"
     else
-      redirect_back(fallback_location: storage_locations_path, error: "Something didn't work quite right -- try again?")
+      redirect_back_or_to(storage_locations_path, error: "Something didn't work quite right -- try again?")
     end
   end
 
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
@@ -14,7 +14,7 @@ def switch_to_role
     role = Role.find(params[:role_id])
     unless current_user.roles.include?(role)
       error_message = "Attempted to switch to a role that doesn't belong to you!"
-      redirect_back(fallback_location: root_path, alert: error_message)
+      redirect_back_or_to(root_path, alert: error_message)
       return
     end
 
@@ -27,21 +27,19 @@ def switch_to_role
   def partner_user_reset_password
     partner = current_organization.partners.find_by(id: params[:partner_id])
     if partner.nil?
-      redirect_back(fallback_location: root_path,
-        alert: "Could not find partner, or you do not have access to this partner!")
+      redirect_back_or_to(root_path, alert: "Could not find partner, or you do not have access to this partner!")
       return
     end
 
     user = User.with_role(:partner, partner)
       .where("LOWER(email) = ?", params[:email].downcase)
       .first
     if user.nil?
-      redirect_back(fallback_location: root_path,
-        alert: "Could not find partner user for this partner with email #{params[:email]}!")
+      redirect_back_or_to(root_path, alert: "Could not find partner user for this partner with email #{params[:email]}!")
       return
     end
 
     user.send_reset_password_instructions
-    redirect_back(fallback_location: root_path, notice: "Password e-mail sent!")
+    redirect_back_or_to(root_path, notice: "Password e-mail sent!")
   end
 end
diff --git a/app/controllers/vendors_controller.rb b/app/controllers/vendors_controller.rb
@@ -68,7 +68,7 @@ def deactivate
       vendor.deactivate!
     rescue => e
       flash[:error] = e.message
-      redirect_back(fallback_location: vendors_path)
+      redirect_back_or_to(vendors_path)
       return
     end
 
@@ -82,7 +82,7 @@ def reactivate
       vendor.reactivate!
     rescue => e
       flash[:error] = e.message
-      redirect_back(fallback_location: vendors_path)
+      redirect_back_or_to(vendors_path)
       return
     end
 
