Merge pull request #5226 from zanetagebka/5222-remove-superuser-ability-to-edit

#5222 | chore: get rid off possibility of editing organization as a admin user

Author: cielf

app/controllers/admin/organizations_controller.rb

@@ -1,20 +1,5 @@
 # [Super Admin] This is for administrating organizations at a global level. We can create, view, modify, etc.
 class Admin::OrganizationsController < AdminController
-  def edit
-    @organization = Organization.find(params[:id])
-  end
-
-  def update
-    @organization = Organization.find(params[:id])
-
-    if OrganizationUpdateService.update(@organization, organization_params)
-      redirect_to admin_organizations_path, notice: "Updated organization!"
-    else
-      flash.now[:error] = @organization.errors.full_messages.join("\n")
-      render :edit
-    end
-  end
-
   def index
     @filterrific = initialize_filterrific(
       Organization.alphabetized,

app/views/admin/organizations/_list.html.erb

@@ -19,7 +19,6 @@
         <td class="date"><%= organization.display_last_distribution_date %></td>
           <td class="text-right">
             <%= view_button_to admin_organization_path(organization.id) %>
-            <%= edit_button_to edit_admin_organization_path(organization.id) %>
             <%= delete_button_to(admin_organization_path(organization.id), { confirm: confirm_delete_msg(organization.name) }) unless (Organization.count <= 1) %>
           </td>
         </tr>

app/views/admin/organizations/edit.html.erb

@@ -60,7 +60,7 @@ def set_up_flipper
   namespace :admin do
     get :dashboard
     resources :base_items
-    resources :organizations
+    resources :organizations, except: %i[edit update]
     resources :partners, except: %i[new create]
     resources :users do
       delete :remove_role

config/routes.rb

@@ -104,41 +104,6 @@
       end
     end
 
-    describe "PATCH #update" do
-      let(:organization) { create(:organization, name: "Original Name") }
-      subject do
-        patch admin_organization_path(id: organization.id, organization: { name: updated_name })
-      end
-
-      context "with a valid update" do
-        let(:updated_name) { "Updated Name" }
-        let(:redirect_status) { 302 }
-
-        it "redirects to #index" do
-          expect(subject).to be(redirect_status)
-          expect(subject).to redirect_to(admin_organizations_path)
-        end
-      end
-
-      context "with an invalid update" do
-        let(:updated_name) { nil }
-        let(:successful) { 200 }
-
-        subject do
-          patch admin_organization_path(id: organization.id, organization: { name: updated_name })
-        end
-
-        it "returns http success" do
-          expect(subject).to be(successful)
-        end
-
-        it "redirects to #edit with an error message" do
-          expect(subject).to render_template("edit")
-          expect(flash[:error]).to be_present
-        end
-      end
-    end
-
     describe "DELETE #destroy" do
       let(:organization) { create(:organization) }
 
@@ -150,15 +115,6 @@
       end
     end
 
-    describe "GET #edit" do
-      let!(:organization) { create(:organization) }
-
-      it "returns http success" do
-        get edit_admin_organization_path({ id: organization.id })
-        expect(response).to be_successful
-      end
-    end
-
     describe "GET #show" do
       let!(:organization) { create(:organization) }
 
@@ -194,13 +150,6 @@
       end
     end
 
-    describe "PUT #update" do
-      it "redirect" do
-        put admin_organization_path({ id: organization.id, organization: { name: "Foo" } })
-        expect(response).to be_redirect
-      end
-    end
-
     describe "DELETE #destroy" do
       it "redirects" do
         delete admin_organization_path({ id: organization.id })
@@ -234,19 +183,5 @@
         expect(response).to be_redirect
       end
     end
-
-    describe "GET #edit" do
-      it "redirects" do
-        get edit_admin_organization_path({ id: organization.id })
-        expect(response).to be_redirect
-      end
-    end
-
-    describe "PUT #update" do
-      it "redirects" do
-        put admin_organization_path({ id: organization.id, organization: { name: "Foo" } })
-        expect(response).to be_redirect
-      end
-    end
   end
 end