Skip to content

#4990 - Items Quantity and Location tab and Item Inventory tab, highlight the bank-wide items that are below their minimum#5123

Merged
dorner merged 8 commits into
rubyforgood:mainfrom
neenu-chacko:4990-highlight-items-below-min-quantity
Apr 4, 2025
Merged

#4990 - Items Quantity and Location tab and Item Inventory tab, highlight the bank-wide items that are below their minimum#5123
dorner merged 8 commits into
rubyforgood:mainfrom
neenu-chacko:4990-highlight-items-below-min-quantity

Conversation

@neenu-chacko
Copy link
Copy Markdown
Contributor

Resolves #4990

Description

  • Highlighted total quantity for items that are under stocked
  • Updated documentation reflecting new changes made
  • Added tests to verify the same

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

How Has This Been Tested?

  • Run spec/system/item_system_spec.rb

Screenshots

Before:
Screenshot 2025-03-27 at 2 26 49 PM

Screenshot 2025-03-27 at 6 59 46 PM

After:
Screenshot 2025-03-27 at 2 33 36 PM

Screenshot 2025-03-27 at 2 36 54 PM

@neenu-chacko neenu-chacko force-pushed the 4990-highlight-items-below-min-quantity branch 2 times, most recently from 24e1b80 to abfc0f0 Compare March 27, 2025 13:49
@neenu-chacko neenu-chacko force-pushed the 4990-highlight-items-below-min-quantity branch from abfc0f0 to b103941 Compare March 27, 2025 13:52
@neenu-chacko neenu-chacko marked this pull request as ready for review March 27, 2025 14:03
Copy link
Copy Markdown
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good functionally. Over to @dorner or @awwaiid for technical comments, if any.

@cielf cielf requested review from awwaiid and dorner March 27, 2025 14:58
Comment thread app/views/items/_item_row_inventory.html.erb Outdated
Comment thread app/views/items/_item_row_quantity_and_storages.html.erb Outdated
Comment thread spec/system/item_system_spec.rb Outdated
@neenu-chacko
Copy link
Copy Markdown
Contributor Author

@dorner I have made some changes. Could you check now?

@dorner dorner merged commit 917f4ad into rubyforgood:main Apr 4, 2025
12 checks passed
@dorner
Copy link
Copy Markdown
Collaborator

dorner commented Apr 4, 2025

Thanks!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2025

@neenu-chacko: Your PR #4990 - Items Quantity and Location tab and Item Inventory tab, highlight the bank-wide items that are below their minimum is part of today's Human Essentials production release: 2025.04.06.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Items Quantity and Location tab and Item Inventory tab, highlight the bank-wide items that are below their minimum

3 participants