Skip to content

5036 catch partner user create errors#5139

Merged
dorner merged 4 commits into
rubyforgood:mainfrom
panacotar:5036-catch-partner-user-create-errors
Apr 4, 2025
Merged

5036 catch partner user create errors#5139
dorner merged 4 commits into
rubyforgood:mainfrom
panacotar:5036-catch-partner-user-create-errors

Conversation

@panacotar
Copy link
Copy Markdown
Contributor

Resolves #5036

Description

I added a rescue statement in PartnerUsersController#create to catch the error from the UserInviteService

The user will be redirected back and shown the error returned by UserInviteService.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

bundle exec rspec spec/requests/partner_users_requests_spec.rb:75

Screenshots

5036

Comment thread spec/requests/partner_users_requests_spec.rb Outdated
Copy link
Copy Markdown
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes functional check. OVer to @dorner for technical comments.

@cielf cielf requested a review from dorner April 4, 2025 00:02
Copy link
Copy Markdown
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here.

@dorner dorner merged commit 9a98627 into rubyforgood:main Apr 4, 2025
11 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2025

@panacotar: Your PR 5036 catch partner user create errors is part of today's Human Essentials production release: 2025.04.06.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Catch error on partner_users#create User already has the requested role so users don't get 500 error

3 participants