Skip to content

5117 add distribution id to partner list distribution#5140

Merged
dorner merged 2 commits into
rubyforgood:mainfrom
panacotar:5117-add-distribution-id-to-partner-list-distribution
Apr 4, 2025
Merged

5117 add distribution id to partner list distribution#5140
dorner merged 2 commits into
rubyforgood:mainfrom
panacotar:5117-add-distribution-id-to-partner-list-distribution

Conversation

@panacotar
Copy link
Copy Markdown
Contributor

Resolves #5117

Description

Included the Distribution's ID in the tables:

  • /partners/dashboard
    • Upcoming Distributions table
    • Prior Distributions table
  • /partners/distributions

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

bundle exec rspec spec/requests/partners/distributions_spec.rb:17

Screenshots

  • /partners/dashboard

  • /partners/distributions

@cielf
Copy link
Copy Markdown
Collaborator

cielf commented Apr 2, 2025

LGTM - over to @dorner for technical input

@cielf cielf requested a review from dorner April 2, 2025 16:07
Copy link
Copy Markdown
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good here.

@dorner dorner merged commit ab65f30 into rubyforgood:main Apr 4, 2025
11 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2025

@panacotar: Your PR 5117 add distribution id to partner list distribution is part of today's Human Essentials production release: 2025.04.06.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add distribution id to the partners list of distributions

3 participants