#4982 - Add "on the fly" addition of donation sites when entering a donation

[neenu-chacko]

Resolves #4982

Description

• Added functionality for on the fly addition of donation site from new donations page
• Added specs to test the same
• Fixed the modal header alignments

Type of change

• New feature (non-breaking change which adds functionality)
• Documentation update

How Has This Been Tested?

• Run rspec spec/system/donation_system_spec.rb

Screenshots

Donation.site.mp4

[cielf]

It'll probably be Monday before I get to reviewing this.

[cielf]

LGTM functionally. Over to @dorner for technical comments.

[dorner]

Using JS ERB is a really old pattern that we'd prefer not using. Turbo and Stimulus are more modern ways of achieving the same goal. Can you look into those approaches? We use them elsewhere in the app.

[cielf]

Hey @dorner -- it looks to me as if @neenu-chacko made the requested changes, but maybe didn't request a re-review. Can you take a look?

[dorner]

@cielf the primary concern hasn't been addressed (the PR is still using JS ERB).

[cielf]

@neenu-chacko Are you still working on this? If we don't hear back in a couple of days, we'll assume that we need someone else to finish this off.

[neenu-chacko]

@cielf Sorry, I missed the messages. I won’t be able to follow up on this anytime soon, so it’s totally fine to pass it on to someone else if needed.

[cielf]

@neenu-chacko Ok .. we'll mark it as open and point to your PR. Please do check back when you can -- sometimes this sort of 'last mile' work isn't picked up quickly.