Partners can view request comment and sender#5160
Merged
dorner merged 5 commits intoApr 25, 2025
Merged
Conversation
jp524
changed the title
Collaborator
|
LGTM functionally -- over to @dorner for technical insight. |
dorner
requested changes
Apr 22, 2025
dorner
approved these changes
Apr 25, 2025
Contributor
|
@jp524: Your PR |
GiovannyCordeiro
pushed a commit
to GiovannyCordeiro/human-essentials
that referenced
this pull request
Jun 6, 2025
* Partner dashboard: add 'comment and sender' to Requests in Progress * Comment is truncated to 20 chars; rest displayed via tooltip * Partner requests: add 'comment and sender' to Request History * Add specs * Refactor script for tooltip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5151
Description
Partners can now view comments for a given request, and the email for the person who made the request ("sender").
Per the issue description I've limited the length of the comments to 20 characters with the remainder displayed as a tooltip.
In order for Bootstrap tooltips to be displayed I had to add a small script on each page, as mentioned in Bootstrap documentation.
Type of change
How Has This Been Tested?
Added some request specs.
Screenshots
Essentials Requests page
Dashboard page
Tooltip demo
Tooltip.Demo.mov