Resolves #5063: Create product drive update button styling improvements#5161
Merged
dorner merged 5 commits intoApr 25, 2025
Conversation
dorner
requested changes
Apr 22, 2025
Collaborator
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Minor nitpick, looks good otherwise.
dorner
approved these changes
Apr 25, 2025
Contributor
|
@rrg1459: Your PR |
GiovannyCordeiro
pushed a commit
to GiovannyCordeiro/human-essentials
that referenced
this pull request
Jun 6, 2025
… improvements (rubyforgood#5161) * change submit button class to use 'btn-success' for better visibility * comment out default button class in SimpleForm configuration * add product_drive model translation to en.yml * fix: correct button text for creating product drives * fix: remove default button class configuration in SimpleForm setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5063
Description
Styling change to product drive buttons - to bring in line with the rest of the system
Type of change
How Has This Been Tested?
bundle exec rspec ./spec/system/product_drive_system_spec.rbScreenshots