4976 enable defaulting to contact name#5163
Conversation
bsbonus
force-pushed
the
4976-enable-defaulting-to-contact-name
branch
from
d97549c to
d15baae
Compare
cielf
left a comment
cielf
left a comment
There was a problem hiding this comment.
@bsbonus Thanks for this!
There is something amiss, still -- I expect it wasn't described in the issue, because it wasn't obvious in the user interface that there is a difference until now.
There are two ways that you can enter a product drive participant -- either by filling in the form in the "Product Drive Participants" section under "Community" -- which is how we described the issue, or by entering it 'on the fly" by selecting "create new participant" in the Product Drive Participant field in a new Donation.
If you use the second method to enter a participant, any participant that doesn't have a business name is appearing as blank in the resultant dropdown.
(They'll appear initially, but not after the entry. If you enter one without a business name, it appears as blank.)
Can you take a look at that aspect, please? Thanks.
…ting a drive participant 'on-the-fly'
|
@cielf yep -- same problem. Good catch, I don't know the app well enough to consider additional flows like that. PR is up for re-review |
|
My bad, I thought the linter was setup to run on save in my ide. Should be sorted |
|
All good here! |
|
@bsbonus: Your PR |
* bug-4976 Defaults dropdown menu to use contact name when no business name is present * bug-4976 updates rendering for contact-name & business name when creating a drive participant 'on-the-fly' * Fixes silly linter mistake in spec file --------- Co-authored-by: Brian Bonus <bonus@MacBookPro.lan>
3 participants
Resolves #4976
Description
The UI was incorrectly rendering null/empty for Product Drive Participant names during the Donation creation form, if the Participant had not included a business name
Type of change
How Has This Been Tested?
Repro:
Sign in as org_admin1@example.com
click on Community, then Product Drive Participant in the left-hand-menu
click on New Product Drive Participant
fill in a contact name and an email - leave business name blank
save
click on Donations, then New Donation in the left-hand menu
Choose Product Drive as source
pick a product drive
click on the product drive participant field.
You will see that there is a blank in the dropdown for the participant you entered.
Screenshots