Fix/5170 reports update issued_at from created_at#5172
Merged
dorner merged 8 commits intoJun 6, 2025
Conversation
cielf
reviewed
Apr 29, 2025
Collaborator
cielf
left a comment
cielf
left a comment
There was a problem hiding this comment.
@zanetagebka Thanks for this! It passes my manual testing -- will ask @dorner for a technical review.
dorner
requested changes
May 2, 2025
dorner
requested changes
May 30, 2025
Collaborator
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
...dangit, lint is failing. Please fix and it'll be ready to merge.
…t' into fix/5170-reports-update-issued-at
Contributor
Author
|
@dorner should be updated |
dorner
approved these changes
Jun 6, 2025
Collaborator
|
Thanks! |
Contributor
|
@zanetagebka: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5170
Description
According to requirements the change was made from created_at to issued_at field, to make sure correct time will be presented.
System tests were added to check that this change leads to correct display of information on the pages.
Changes were made for 3 reports: donations, purchases and distributions.
Type of change
How Has This Been Tested?
System tests