4981 adjuments export with item changes#5173
Conversation
cyang-el
changed the title
cyang-el
changed the title
cyang-el
force-pushed
the
4981-adjuments-export-with-item-changes
branch
from
a7b1d73 to
c8a01d2
Compare
|
@cyang-el Oh -- the rubocop linter pass is failing, so you'll want to check into that. Thanks! |
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Really minor request, otherwise this looks good!
|
|
||
| it "includes appropriate headers and data" do | ||
| csv = <<~CSV | ||
| Created date,Storage Area,Comment,# of changes,#{item1.name},#{item2.name} |
There was a problem hiding this comment.
We know the name, can we put the hardcoded value in here?
There was a problem hiding this comment.
good point, let me quickly change that :)
There was a problem hiding this comment.
@dorner should I squash this and the last change to a single commit and then force push? to not create too much commit noise
There was a problem hiding this comment.
@cyang-el no, that's what merge commits are for. 😄 Force push causes havoc with existing comments.
|
@dorner it seems that the lint errors are due to ItBlocks, and it's triggered by files not touched in this PR. I am guessing we might run into the same error if we run linter on main branch as well (could be due to rubocop version upgrade I guess), I can fix it here in this PR or another one (seems like a better option to me), what do you think? |
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Merged main branch in and everything passes.
|
@cyang-el: Your PR |
* Add specs for adjusment csv export * Add service for csv exporting adjustments * Change header to comply with existing documentation * Lint the specs * Move adjustment export format tests into requests spec * Adapt adjustments specs to test csv export text and use module method * Hardcode adjustments_requests spec strings --------- Co-authored-by: Daniel Orner <daniel.orner@flipp.com>
3 participants
Resolves #4981
Description
We want to allow user to be able to see the changes for all items in each adjustment.
Type of change
How Has This Been Tested?
bundle exec rake.Adjustments-2025-04-29.csv