Finish removal of Organization short name - Part 1#5186
Merged
Conversation
Collaborator
|
@dorner -- I think this one is mostly in your wheelhouse -- I'll need to do a sanity check once you've ok'd it just to make sure I cant break the current organization stuff. |
dorner
approved these changes
May 9, 2025
Collaborator
dorner
left a comment
There was a problem hiding this comment.
This looks amazing - thank you so much for the tedious work on this one!
Collaborator
|
@cielf feel free to merge at will. |
Collaborator
|
Sanity check completed -- Not exhausitive, but I'm pretty confident. |
Contributor
|
@jp524: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5167
Description
I removed the organization's short name from URLs last year in #4331. We now want to remove the column from the Organization table and ensure that everything still works.
This PR is best reviewed commit by commit.
Checklist from issue:
-> I introduced the param
organization_idwhere required-> There were quite a few spots were
organization_namewas used but no longer required. I cleaned that up as well-> Removing a column requires the migration needs to be to done in multiple steps based on the Strong Migrations docs. I've done the first step (ignoring the column) in this PR. Finish removal of Organization short name - Part 2 #5187 contains the migration and can only be ran after this PR has been deployed
Type of change
How Has This Been Tested?
Modified existing specs and ensured that they passed.
Screenshots
n/a