Skip to content

Finish removal of Organization short name - Part 2#5187

Merged
dorner merged 3 commits into
rubyforgood:mainfrom
jp524:5167-remove-org-short-name-part-2
May 23, 2025
Merged

Finish removal of Organization short name - Part 2#5187
dorner merged 3 commits into
rubyforgood:mainfrom
jp524:5167-remove-org-short-name-part-2

Conversation

@jp524
Copy link
Copy Markdown
Contributor

@jp524 jp524 commented May 4, 2025

Resolves #5167

Description

Contains migration to remove column short_name from Organization.
According to Strong Migrations docs, this PR should be deployed only after #5186 has been deployed.

Only the last commit of this PR is needed. The first nine are included in Part 1. I included them here too for CI to pass and because I can't set my branch as the base repo (don't have collaborator permissions). I'll rebase on main once Part 1 has been merged

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

See #5186

Screenshots

n/a

@cielf cielf requested a review from dorner May 5, 2025 18:33
Copy link
Copy Markdown
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - let's move this to Draft status so we don't accidentally merge.

Comment thread db/migrate/20250504183911_remove_short_name_from_organizations.rb
@dorner dorner marked this pull request as draft May 9, 2025 19:22
@jp524 jp524 marked this pull request as ready for review May 19, 2025 18:58
@cielf
Copy link
Copy Markdown
Collaborator

cielf commented May 20, 2025

@dorner -- Is there any reason we wouldn't just go ahead and merge this now?

@dorner
Copy link
Copy Markdown
Collaborator

dorner commented May 23, 2025

It was blocked on #5186 which is now merged.

@dorner dorner merged commit 495d1c0 into rubyforgood:main May 23, 2025
11 checks passed
@jp524 jp524 deleted the 5167-remove-org-short-name-part-2 branch May 23, 2025 20:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2025

@jp524: Your PR Finish removal of Organization short name - Part 2 is part of today's Human Essentials production release: 2025.06.01.
Thank you very much for your contribution!

GiovannyCordeiro pushed a commit to GiovannyCordeiro/human-essentials that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Finish removal of organization short name

3 participants