5166: Remove item category#5205
Conversation
cielf
left a comment
cielf
left a comment
There was a problem hiding this comment.
I'm puzzled as to why we're removing the short name in this PR since I thought it had already been removed. Also, the tests are failing after multiple reruns.
| @@ -1,8 +1,12 @@ | |||
| class RemoveShortNameFromOrganizations < ActiveRecord::Migration[8.0] | |||
There was a problem hiding this comment.
Didn't we already remove the short name in #5187?
There was a problem hiding this comment.
This isn't a new migration, it's just adding a check inside it so it wouldn't crash if it already ran.
|
Back on me. per discussion with D in sunday meeting. Migration was changed so it wouldn't crash if it ran again. |
cielf
left a comment
cielf
left a comment
There was a problem hiding this comment.
Hey @dorner -- it looks like there are references to category in the request specs, though -- For instance, in item_requests_spec.rb:
item_pullups = create(:item, name: "the most wonderful magical pullups that truly potty train", category: "Magic Toddlers", on_hand_minimum_quantity: 100)
|
Should be fixed now! |
|
@dorner: Your PR |
2 participants
Confirmed this field is not used anywhere and there is no data in it since 2019.