#5222 | chore: get rid off possibility of editing organization as a admin user#5226
Merged
cielf merged 2 commits intoJun 10, 2025
Merged
Conversation
- remove controller actions - remove tests that became redundant - update routes to not create one for edit and update
…ove-superuser-ability-to-edit # Conflicts: # app/views/admin/organizations/edit.html.erb # spec/requests/admin/organizations_requests_spec.rb
Collaborator
|
Functionality works. over to @dorner for technical once over |
dorner
approved these changes
Jun 6, 2025
Collaborator
|
@zanetagebka is there a reason this is still in Draft? |
Contributor
Author
|
@dorner I wanted to make sure that everything is cleaned up and I did not have time to do so, so I kept it as draft. |
Contributor
|
@zanetagebka: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5222
Description
Please also include relevant motivation and context.
Guide questions:
List any dependencies that are required for this change. (gems, js libraries, etc.)
Include anything else we should know about. -->
Type of change
How Has This Been Tested?
It was tested by-hand to see visual changes. Also automated tests were checked and since it was removing of feature I simply removed tests that currently are not needed.
Screenshots
Before:
After:
