5250 add quota to pick sheets#5264
Merged
dorner merged 5 commits intoJul 4, 2025
Merged
Conversation
cielf
previously requested changes
Jul 3, 2025
cielf
left a comment
cielf
left a comment
Collaborator
There was a problem hiding this comment.
Hi @yahyaelganyni1 Thank you for this! I've got one issue that needs to be addressed
from the functional testing
The quota section should not appear if the quota is not set or is 0.
This is because many banks do not use the quota feature.
…when set and greater than zero
Collaborator
|
Passes functional check. Over to @dorner for technical wisdom. |
Contributor
|
@yahyaelganyni1: Your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5250
Description
This change adds functionality to display the partner's quota information in the generated PDF. The quota is retrieved from the partner's profile and defaults to 0 if no quota is set. This feature ensures that organizations can clearly communicate quota limits to their partners, improving transparency and accountability.
Tests have been added to verify that the quota is displayed correctly, including scenarios where the quota is set and where it defaults to zero.
Type of change
How Has This Been Tested?
This feature has been tested by adding unit tests to verify the correct rendering of quota information in the generated PDF. The tests cover scenarios where:
The partner has a defined quota.
The partner has no quota set, ensuring it defaults to 0.
The tests were run locally using bundle exec rake, and all existing and new tests passed successfully. No additional configuration is required to verify the changes.
Screenshots