Picklists should be filterable + regression testing#5397
Closed
jonny5 wants to merge 5 commits into
Closed
Conversation
- Generate the pdf and add to fixture - Rename content in PDFComparisonTestFactory to be more domain specific - Add compare_pdf to spec to compare the file to the
jonny5
commented
Sep 13, 2025
| end | ||
|
|
||
| def self.render_pdf_at_year_end(organization, distribution) | ||
| def self.render_distribution_pdf_at_year_end(organization, distribution) |
Collaborator
Author
There was a problem hiding this comment.
I resisted refactoring this class too much and just renamed the relevant places to scope to distribution/picklist
jonny5
commented
Sep 13, 2025
| create_distribution_comparison_pdf(storage_creation, :create_profile_with_incomplete_address, file_paths.expected_incomplete_address_file_path, :delivery) | ||
| create_distribution_comparison_pdf(storage_creation, :create_profile_no_contact_with_program_address, file_paths.expected_no_contact_file_path, :delivery) | ||
|
|
||
| create_picklist_comparison_pdf(storage_creation, :create_partner_with_quota, :create_profile_with_pickup_person, file_paths.expected_picklist_file_path) |
Collaborator
Author
There was a problem hiding this comment.
Added one PDF with relevant header data, I didn't see so much conditionality in the pdf that it would vary greatly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #5148 (see that PR for full description/discussion)
Resolves #4985
Description