Clear selected resource when role type changes#5574
Merged
janeewheatley merged 1 commit intoMay 31, 2026
Merged
Conversation
dorner
approved these changes
May 29, 2026
Collaborator
|
Looks OK, but the fact that "Ruby is not available on this machine" makes me leery of this. @ruestitch @janeewheatley over to you for QA. |
Collaborator
|
I pulled this down and verified locally. Nice job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5565. Summary: clear the selected resource whenever the role resource type changes in the double select controller; add a system spec covering the Organization to Partner switch without selecting a new partner resource. Validation: git show --check; node --check app/javascript/controllers/double_select_controller.js. Local RSpec was not run because Ruby is not available on this machine. The regression is covered by the added system spec and ready for the project's CI.